Fix i18n and syncing problems

Author: facchinm

src/arduino.cc/builder/phases/sizer.go

@@ -31,9 +31,9 @@ package phases
 
 import (
 	"errors"
-	"os"
 	"regexp"
 	"strconv"
+	"time"
 
 	"arduino.cc/builder/builder_utils"
 	"arduino.cc/builder/constants"
@@ -52,6 +52,9 @@ func (s *Sizer) Run(ctx *types.Context) error {
 
 	err := checkSize(buildProperties, verbose, warningsLevel, logger)
 	if err != nil {
+		// HACK: we are bailing out badly and we just wrote on stdout,
+		// wait 200 ms to let the IDE's MessageSiphon flush
+		time.Sleep(200 * time.Millisecond)
 		return i18n.WrapError(err)
 	}
 
@@ -86,27 +89,29 @@ func checkSize(buildProperties properties.Map, verbose bool, warningsLevel strin
 		return err
 	}
 
-	logger.Fprintln(os.Stdout, logLevel, "Sketch uses {0} bytes ({2}%%) of program storage space. Maximum is {1} bytes.", strconv.Itoa(textSize), strconv.Itoa(maxTextSize), strconv.Itoa(textSize*100/maxTextSize))
+	logger.Println(logLevel, "Sketch uses {0} bytes ({2}%%) of program storage space. Maximum is {1} bytes.", strconv.Itoa(textSize), strconv.Itoa(maxTextSize), strconv.Itoa(textSize*100/maxTextSize))
 	if dataSize > 0 {
 		if maxDataSize > 0 {
-			logger.Fprintln(os.Stdout, logLevel, "Global variables use {0} bytes ({2}%%) of dynamic memory, leaving {3} bytes for local variables. Maximum is {1} bytes.", strconv.Itoa(dataSize), strconv.Itoa(maxDataSize), strconv.Itoa(dataSize*100/maxDataSize), strconv.Itoa(maxDataSize-dataSize))
+			logger.Println(logLevel, "Global variables use {0} bytes ({2}%%) of dynamic memory, leaving {3} bytes for local variables. Maximum is {1} bytes.", strconv.Itoa(dataSize), strconv.Itoa(maxDataSize), strconv.Itoa(dataSize*100/maxDataSize), strconv.Itoa(maxDataSize-dataSize))
 		} else {
-			logger.Fprintln(os.Stdout, logLevel, "Global variables use {0} bytes of dynamic memory.", strconv.Itoa(dataSize))
+			logger.Println(logLevel, "Global variables use {0} bytes of dynamic memory.", strconv.Itoa(dataSize))
 		}
 	}
 
 	if textSize > maxTextSize {
-		return errors.New("Sketch too big; see http://www.arduino.cc/en/Guide/Troubleshooting#size for tips on reducing it.")
+		i18n.ErrorfWithLogger(logger, "Sketch too big; see http://www.arduino.cc/en/Guide/Troubleshooting#size for tips on reducing it.")
+		return errors.New("")
 	}
 
 	if maxDataSize > 0 && dataSize > maxDataSize {
-		return errors.New("Not enough memory; see http://www.arduino.cc/en/Guide/Troubleshooting#size for tips on reducing your footprint.")
+		i18n.ErrorfWithLogger(logger, "Not enough memory; see http://www.arduino.cc/en/Guide/Troubleshooting#size for tips on reducing your footprint.")
+		return errors.New("")
 	}
 
 	if properties["build.warn_data_percentage"] != "" {
 		warnDataPercentage, _ := strconv.Atoi(properties["build.warn_data_percentage"])
 		if maxDataSize > 0 && dataSize > maxDataSize*warnDataPercentage/100 {
-			logger.Fprintln(os.Stdout, logLevel, "Low memory available, stability problems may occur.")
+			logger.Println(logLevel, "Low memory available, stability problems may occur.")
 		}
 	}
 
@@ -118,7 +123,8 @@ func execSizeReceipe(properties properties.Map, logger i18n.Logger, textSize *in
 	out, err := builder_utils.ExecRecipe(properties, constants.RECIPE_SIZE_PATTERN, false, false, false, logger)
 
 	if err != nil {
-		return errors.New("Couldn't determine program size: {0}")
+		i18n.ErrorfWithLogger(logger, "Couldn't determine program size")
+		return errors.New("")
 	}
 
 	// force multiline match prepending "(?m)" to the actual regexp