Skip to content

BlockDevices: minor fixes to cleanup compile warnings #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 24, 2025
Merged

BlockDevices: minor fixes to cleanup compile warnings #444

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a8d4998
QSPIFlashBlockDevice: fix ctor init order
pennam Feb 14, 2025
de06a61
QSPIFlashBlockDevice: fix pointer aritmetic
pennam Feb 14, 2025
87c7070
QSPIFlashBlockDevice: fix signed/unsigned comparison
pennam Feb 14, 2025
2fe862e
SDCardBlockDevice: remove unused variable
pennam Feb 14, 2025
12b34e3
SDCardBlockDevice: fix signed/unsigned comparison
pennam Feb 14, 2025
c265d86
SDCardBlockDevice: fix ctor initialization order
pennam Feb 14, 2025
1cee16b
SDCardBlockDevice: avoid double cast
pennam Feb 24, 2025
e79d4ff
SDCardBlockDevice: avoid double cast
pennam Feb 24, 2025
e8858c0
storage_common: fix signed comparison
pennam Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SDCardBlockDevice: fix signed/unsigned comparison
  • Loading branch information
@pennam
pennam committed Feb 24, 2025
commit 12b34e36b930e4bd3c17abb0972fe222caef2a3e
10 changes: 5 additions & 5 deletions libraries/BlockDevices/SDCardBlockDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,8 @@ int SDCardBlockDevice::read(void *buffer, bd_addr_t add, bd_size_t _size) {
uint32_t num_of_blocks = (_size / read_block_size);
uint32_t start_add_of_block = (add / read_block_size);
rv = FSP_SUCCESS;
for(int i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
rv = R_SDHI_Read (&ctrl, (uint8_t *)(buffer + (i * read_block_size)), start_add_of_block + i, 1);
for(uint32_t i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
rv = R_SDHI_Read (&ctrl, (uint8_t *)((uint8_t *)buffer + (i * read_block_size)), start_add_of_block + i, 1);
if(rv == FSP_SUCCESS) {
rv = wait_for_completition();
}
Expand Down Expand Up @@ -403,8 +403,8 @@ int SDCardBlockDevice::write(const void *buffer, bd_addr_t add, bd_size_t _size)
uint32_t num_of_blocks = (_size / write_block_size);
uint32_t start_block_number = (add / write_block_size);
rv = FSP_SUCCESS;
for(int i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
rv = R_SDHI_Write (&ctrl, (uint8_t *)(buffer + (i * write_block_size)), start_block_number + i, 1);
for(uint32_t i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
rv = R_SDHI_Write (&ctrl, (uint8_t *)((uint8_t *)buffer + (i * write_block_size)), start_block_number + i, 1);
if(rv == FSP_SUCCESS) {
rv = wait_for_completition();
}
Expand Down Expand Up @@ -438,7 +438,7 @@ int SDCardBlockDevice::erase(bd_addr_t add, bd_size_t _size) {
uint32_t num_of_blocks = (_size / erase_block_size);
uint32_t start_block_number = (add / erase_block_size);
rv = FSP_SUCCESS;
for(int i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
for(uint32_t i = 0; i < num_of_blocks && rv == FSP_SUCCESS; i++) {
rv = R_SDHI_Erase (&ctrl, start_block_number + i, 1);
if(rv == FSP_SUCCESS) {
rv = wait_for_completition();
Expand Down