Skip to content

[WIP] Baud autodetect #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Baud autodetect #355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c78fd2b
Unifying codestyle
andreagilardoni Jul 17, 2024
6f0102d
Improving parse function in modem class
andreagilardoni Jul 17, 2024
7f88390
adding a third level of debug
andreagilardoni Jul 18, 2024
9ce159f
removing unused methods
andreagilardoni Jul 22, 2024
2cdcca5
[WIP baudrate autodetection]
andreagilardoni Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing unused methods
  • Loading branch information
@andreagilardoni
andreagilardoni committed Jul 29, 2024
commit 9ce159f52e4c21a82f30c99a76f58e4128412c5e
4 changes: 2 additions & 2 deletions libraries/WiFiS3/src/Modem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
using namespace std;

/* -------------------------------------------------------------------------- */
ModemClass::ModemClass(int tx, int rx) : beginned(false), delete_serial(false), _timeout(MODEM_TIMEOUT), trim_results(true), read_by_size(false) {
ModemClass::ModemClass(int tx, int rx) : beginned(false), delete_serial(false), _timeout(MODEM_TIMEOUT), trim_results(true) {
/* -------------------------------------------------------------------------- */
_serial = new UART(tx,rx);
}

/* -------------------------------------------------------------------------- */
ModemClass::ModemClass(UART * serial) : beginned(false) , delete_serial(true) , _serial(serial), _timeout(MODEM_TIMEOUT), trim_results(true), read_by_size(false) {
ModemClass::ModemClass(UART * serial) : beginned(false) , delete_serial(true) , _serial(serial), _timeout(MODEM_TIMEOUT), trim_results(true) {
/* -------------------------------------------------------------------------- */
}

Expand Down
4 changes: 1 addition & 3 deletions libraries/WiFiS3/src/Modem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ModemClass {
}

void read_using_size() {
read_by_size = true;
// read_by_size = true; // deprecated
}
bool beginned;

Expand Down Expand Up @@ -79,8 +79,6 @@ class ModemClass {
unsigned long _timeout;
uint8_t tx_buff[MAX_BUFF_SIZE];
bool trim_results;
bool read_by_size;
bool read_by_size_finished(std::string &rx);
Stream * _serial_debug;
uint8_t _debug_level = 0;
};
Expand Down
Loading