Skip to content

Allow customization of transmit and receive buffer sizes for I2C 'Wire' object. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow customization of transmit and receive buffer sizes for I2C 'Wire' object. #589

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59355fe
Renamed twi.c to twi.cpp
dac1e Jan 2, 2025
56ef4a4
Make Wire and twi buffers weak and allow to override by macro
dac1e Jan 2, 2025
cb707b8
Moved macros from twi.h to twi.cpp.
dac1e Jan 3, 2025
7d5eae1
Moved Wire api functions that do just type cast from .cpp file to .h
dac1e Jan 3, 2025
c1eaa79
Use C++ static_cast instead of C cast.
dac1e Jan 3, 2025
b9df583
Use override specifier in Wire.h
dac1e Jan 3, 2025
4962837
Deleted obsolete debug code.
dac1e Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use C++ static_cast instead of C cast.
  • Loading branch information
@dac1e
dac1e committed Jan 3, 2025
commit c1eaa792574b1647cadee93e93d60d5c4618139a
26 changes: 13 additions & 13 deletions libraries/Wire/src/Wire.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,25 +57,25 @@ class TwoWire : public Stream
bool getWireTimeoutFlag(void);
void clearWireTimeoutFlag(void);
void beginTransmission(uint8_t);
void beginTransmission(int address) {beginTransmission((uint8_t) (address));}
inline void beginTransmission(int address) {beginTransmission(static_cast<uint8_t> (address));}
uint8_t endTransmission(void);
uint8_t endTransmission(uint8_t);
uint8_t requestFrom(uint8_t, uint8_t, uint32_t, uint8_t, uint8_t);
uint8_t requestFrom(uint8_t address, uint8_t quantity) {
return requestFrom((uint8_t) (address), (uint8_t) (quantity),
(uint8_t) (true));
inline uint8_t requestFrom(uint8_t address, uint8_t quantity) {
return requestFrom(static_cast<uint8_t>(address), static_cast<uint8_t>(quantity),
static_cast<uint8_t> (true));
}
uint8_t requestFrom(uint8_t address, uint8_t quantity, uint8_t sendStop) {
return requestFrom((uint8_t) (address), (uint8_t) (quantity),
(uint32_t) (0), (uint8_t) (0), (uint8_t) (sendStop));
inline uint8_t requestFrom(uint8_t address, uint8_t quantity, uint8_t sendStop) {
return requestFrom(static_cast<uint8_t>(address), static_cast<uint8_t>(quantity),
static_cast<uint32_t>(0), static_cast<uint8_t>(0), static_cast<uint8_t>(sendStop));
}
uint8_t requestFrom(int address, int quantity) {
return requestFrom((uint8_t) (address), (uint8_t) (quantity),
(uint8_t) (true));
inline uint8_t requestFrom(int address, int quantity) {
return requestFrom(static_cast<uint8_t>(address), static_cast<uint8_t>(quantity),
static_cast<uint8_t>(true));
}
uint8_t requestFrom(int address, int quantity, int sendStop) {
return requestFrom((uint8_t) (address), (uint8_t) (quantity),
(uint8_t) (sendStop));
inline uint8_t requestFrom(int address, int quantity, int sendStop) {
return requestFrom(static_cast<uint8_t>(address), static_cast<uint8_t>(quantity),
static_cast<uint8_t>(sendStop));
}
virtual size_t write(uint8_t);
virtual size_t write(const uint8_t *, size_t);
Expand Down