BLE: combination of 337, 342 & xieqi's commit #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Know issues: 1. Memory issue. Some times the memcmp not work correct. 2. Central not complete. But can do scan.
1. Add the auto discover 2. Resolve the connect request was not scheduled issue 3. Implement the read/write request
Note: need change the compiler parameter in platform.txt. "compiler.c.flags=-c -std=gnu11 -mcpu=quarkse_em -mlittle-endian -g -Os ..." to "compiler.c.flags=-c -std=gnu11 -mcpu=quarkse_em -mlittle-endian -g -O0" "compiler.cpp.flags=-c -mcpu=quarkse_em -mlittle-endian -g -Os ..." to "compiler.cpp.flags=-c -mcpu=quarkse_em -mlittle-endian -g -O0 ..."
1. Add the Notify/Indicate feature 2. Add the notify central/peripheral example sketches
1. Fix the callback doesn't work issue 2. Fix the Klock scan issue
Notice: Not test on IDE
1. The discover can support mutiple services in GATT server. 2. The attributes doesn't include the CCCD and make regiter service failed
1. Enable buffer advertisment from peripheral 2. Enable ADV's RSSI 3. Enable scan without parameter
1. Support valueupdated event 2. Change the balloc/bfree to malloc/free 3. Change return type from BLE_STATUS_T to int
1. Implement BLEAttributeWithValue class 2. Change the code structure 3. Change the return value
Change -Os to -O0.
…sed by device and on sticker
1. Update example sketches; 2. Check the NULL pointers; 3. Add the writeValue to the template; 4. Delete reference in callback parameters;
Previously this method was returning the address of a function-local variable. All example sketches for Central were attempting to access this address after the method had returned, so would have invoked undefined behaviour.
Apparently advertisedServicesUuid() has never worked. It should work now.
These methods were returning the address of a local variable. This commit fixes that, as well modifying the numerous uses of this function to comply with the new API.
|
Adding @russmcinnis and @nfpaz as reviewers and testers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SidLeung, test this one please. #342 is still active, just in case this integration breaks something