XBee automatic reset #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally without soldering RTS to D3 on the local XBee.
…the display is out of sync with the xbee. Removed debugging code. Modified the ZigBee code to return the result from any commands issued. This makes it possible to create a UI to issue arbitrary commands.
|
From my point of view, this is ready to pull now. Please actually pull it or comment on what additional changes are needed. |
…tering command mode work on a busy serial line. Fixed the select a serial port dialog box to skip the Xbee and separator entries.
cmaglie
added
feature request
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Bugfix for gateway signing requirements
|
I'm looking through some older PRs and came across this one. It's not entirely clear to me what this adds, but looking at the code it seems that a lot of special casing is added for connection to or through an XBee or Zigbee device, which does not really look like it belongs in the Arduino IDE. I'm closing this PR since it's old, unclear and does not look like it fits with the IDE. If you disagree, feel free to comment and explain more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some much better code to automatically reset FIOs attached to XBee's. It's useable, but still has all the debugging code in. I'd still like to add code to allow the user to add arbitrary remote commands. Make commands other than AC do a commit. There is also a couple of occasional bugs where the XBees get out of sync and the easiest solution is to just exit the app and restart.
I don't really want this pulled. I'd like comments on the UI. Any important code changes (such as there is currently no provision to internationalize any of the strings) requested and general comments.
Don't worry about this until after the release.