Adding HttpClient #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a periodic call to the new method Ethernet.maintain() http://code.google.com/p/arduino/issues/detail?id=716
Conflicts: libraries/Ethernet/Dhcp.cpp libraries/Ethernet/Ethernet.cpp libraries/Ethernet/Ethernet.h
…t in order to output what is sent/received with it (to aid in debugging things like network protocols - you attach Serial to the EthernetClient, for example, and it'll dump all the data sent/received to the serial port)
cmaglie
added
feature request
|
@amcewen |
cmaglie
added
the
Waiting for feedback
|
@cmaglie yes, that makes sense (unless you'd like to take it into the core, in which case I could work up a new version...) |
|
Thanks!
Having it into the core is a maintenance burden and adds delays in the update process. |
|
Hehe, I'm not sure I'm "active", more sporadic I think ;-) |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
ATSHA204 personalization sketch updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the HttpClient, updated as per discussions on the Developers list (including using completed() rather than eof().