Upgrade Serial Plotter #5443
Merged
Upgrade Serial Plotter #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
approved these changes
Oct 4, 2016
|
I hope Arduino devs can merge this since it makes the Serial Plotter much more useful. If there are issues with the way I did things let me know? |
cmaglie
reviewed
Oct 17, 2016
| private final Font font; | ||
| private final Color bgColor; | ||
| private final Color gridColor = new Color(245, 245, 245, 245); |
There was a problem hiding this comment.
This color should be put into the theme and retrieved with something like Theme.getColor("plotting.gridcolor")
| @@ -132,16 +134,58 @@ public void paintComponent(Graphics g1) { | |||
| Rectangle2D fRect = fm.getStringBounds(String.valueOf(tick), g); | |||
| xOffset = Math.max(xOffset, (int) fRect.getWidth() + 15); | |||
|
|
|||
| g.setColor(Color.BLACK); | |||
There was a problem hiding this comment.
And probably this one too, even if it wasn't present before, it may be encoded as plotting.axiscolor
|
Even better, I like using the theme.txt for the grid colors, still trying to get handle on how everything fits together. I'll try to make this work. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a x-axis and labels, grid lines, more y-axis ticks and moves Serial Baud Rate combo box to the other side to reflect the look of the Serial Monitor. It also scales right when the window is scaled.
Before:
After:
