Skip to content

Git integration inside the IDE (commit only) #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

baydindima
Copy link

@baydindima baydindima commented Apr 14, 2016

Сompletely rewrote the code #4704. Now I am using library for work with Git. Now you can init new repository, commit and log commits. This is solve the issue arduino/arduino-ide#1880.
@cmaglie please review and comment my solution.

@carlosperate
Copy link
Contributor

Just for reference, relating this other PR here: #4816

@baydindima
Copy link
Author

Added ability to perform diff and reset.

@baydindima
Copy link
Author

Added GUI for Diff

@cmaglie
Copy link
Member

cmaglie commented Apr 28, 2016

wow, three pull request for git integration in three weeks. It seems that there is a very compelling need to add Git to the Arduino IDE

@carlosperate @baydindima
I see that you, both, added more features than the original poster asked in arduino/arduino-ide#1880. Probably you felt the need to have something more than just a "Commit" command, but even now that those "extra" features are there, they are poorly implemented and leaves a lot to desire. BTW I'm not listing here what works and what not, this is not the purpose of this message and I don't want to do GUI design considerations here, what I want to know from you guys, is if you are willing to invest time to work seriously on this feature. As I already said a proper Git integration (even only the basic commands) is a project on his own.

If the answer is yes, you should probably start the git integration as an Arduino IDE Tool Plugin, in his own repository so people can start to tinker with it and give feedbacks. Here some examples:

https://github.com/esp8266/arduino-esp8266fs-plugin
https://github.com/me-no-dev/EspExceptionDecoder
https://github.com/sandeepmistry/arduino-nRF5/tree/master/extras/ide-tools

Moreover I'd like to see you cooperate instead of competing each other, developers time is a scarce resource!

@carlosperate
Copy link
Contributor

@cmaglie, I think you meant @CarlosMiguelCuevas, posting here so that he can get the notification as well.

@cmaglie
Copy link
Member

cmaglie commented Apr 28, 2016

oh yes thanks! sorry for the confusion

@fededim
Copy link

fededim commented Jun 29, 2017

Any plan solve the conflicts and to merge this PR ?

@silbo
Copy link

silbo commented Apr 10, 2019

Awesome stuff, would be epic to see it in production.
This work just stopped ? Anyone working on merging it ?

@CarlosMiguelCuevas
Copy link

@cmaglie I won't be able to continue working on this, actually, I just closed my PR (if someone is interested in the code, the branch was not deleted so the code is there). I didn't check @baydindima 's code but it seems he went furder. so make it happen and good luck.

@cmaglie cmaglie closed this Jul 18, 2019
@per1234 per1234 added Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix) Type: Wontfix Arduino has decided that it will not resolve the reported issue or implement the requested feature labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix) Type: Wontfix Arduino has decided that it will not resolve the reported issue or implement the requested feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants