Skip to content

Fix for #2969 #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix for #2969 #3100

wants to merge 1 commit into from

Conversation

agdl
Copy link
Member

@agdl agdl commented May 7, 2015

No description provided.

@matthijskooijman
Copy link
Collaborator

Could you please give this commit a proper commit message, that describes what it does? Just referencing to an issue isn't very friendly wrt searching / scanning of the commit log, and makes the commit message useless if the issue list ever gets lost. If you want to refer to an issue, use the "Fixes #2969" syntax somewhere in the commit message body (i.e. not the first line), which will even cause github to autoclose the issue.

@bperrybap
Copy link

The new example code in the repo with address 8 looks ok, it might also be useful to update the actual web page here:
http://www.arduino.cc/en/Tutorial/MasterWriter
with a note indicating that i2c addresses 0-7 should be avoided as those are reserved.

@ffissore
Copy link
Contributor

ffissore commented May 7, 2015

Indeed @agdl . This is not the first time. Hopefully it's the last

@ffissore ffissore closed this May 7, 2015
@bperrybap
Copy link

Huh? I'm now totally lost.
Is the Tutorial web page going to be updated to include a text note about not using reserved addresses 0-7?
Fixed examples is great but I think users should also be warned about using the reserved addresses in the descriptive text.

@agdl
Copy link
Member Author

agdl commented May 7, 2015

@bperrybap the on-line page take the code from git so it is automatically updated when the PR is merged. For the descriptive part i added this statement here:
www.arduino.cc/en/Reference/Wire

"However the addresses from 0 to 7 are not used because are reserved so the first address that can be used is 8. "

@bperrybap
Copy link

Cool. Very nice. Thank You.

@matthijskooijman
Copy link
Collaborator

Why is this closed?

@ffissore
Copy link
Contributor

ffissore commented May 8, 2015

So @agdl can make another one, with a proper commit message, and a proper PR title and a proper PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants