Skip to content

Print and PrintFormat #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Print and PrintFormat #2743

wants to merge 1 commit into from

Conversation

MichaelJonker
Copy link

Changed or added files (7) :
code for Print and PrintFormat classes (in folder hardware/arduino/avr/cores/arduino/

  • Print.h
  • Print.cpp
  • PrintFormat.h

code for demo sketch (in folder build/shared/examples/11.Print/PrintNewFeaturesDemo)

  • PrintNewFeaturesDemo.ino // demo sketch
  • PrintDemo.cpp // extra
  • PrintSequenceTeaser.cpp // extra
  • .gitignore // ignore

The demo sketch is available in the IDE from examples/11.Print

See also discussion on "Print enhancement available for review" on:
https://groups.google.com/a/arduino.cc/forum/?fromgroups#!topic/developers/NWnjeSyuNek

Michael Jonker

@ffissore ffissore changed the title pull request version Print and PrintFormat Mar 11, 2015
@ffissore
Copy link
Contributor

@ArduinoBot build this please

@facchinm
Copy link
Member

Hi @MichaelJonker, I tested the modification with a trivial sketch (one println) and the storage space used jumped from 2150 to 2950 bytes, RAM from 182 to 272 bytes... Not a big deal if the aim was keeping the previous memory footprint.
However, the code is good and maybe a lot of people would love to use it, but maybe the best tradeoff could be providing it as an addon without touching the existing codebase (which will also let you get rid of the legacy compatibility "hacks" while being sure that existing sketch won't stop working).
Would you mind modifying the pull request to provide your functions as printFormat and printlnFormat? Also, if you could review the comments and remove all the useless ones (also from the example) before submission it would be great 😉

@facchinm facchinm added the Waiting for feedback More information must be provided before we can proceed label Mar 17, 2015
@cmaglie cmaglie added Component: Core Related to the code for the standard Arduino API feature request A request to make an enhancement (not a bug fix) labels Apr 15, 2015
@NicoHood
Copy link
Contributor

Is this of any help?
https://github.com/arduino/Arduino/issues/3546

@facchinm facchinm added the Print and Stream class The Arduino core library's Print and Stream classes label Jan 20, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


MichaelJonker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MichaelJonker MichaelJonker closed this by deleting the head repository Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Related to the code for the standard Arduino API feature request A request to make an enhancement (not a bug fix) Print and Stream class The Arduino core library's Print and Stream classes Waiting for feedback More information must be provided before we can proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants