update Sketch menu, add Save hex option #2567
Conversation
|
|
championswimmer
force-pushed
the
ide-1.5.x-saveHex
branch
from
2ee74d9 to
17f74a5
Compare
|
|
|
@cmaglie This can be considered ? |
| sketchMenu.add(item); | ||
|
|
||
|
|
||
| item = newJMenuItemAlt("Export compiled Binary", 'S'); |
There was a problem hiding this comment.
May you add the _("....") syntax? so the menu string can be translated.
|
Hi Arnav! I've added just two simple comments inline. Besides that, it looks ready to be merged. C |
|
I see that on sam also we are using the terminology "hex", although the built files are not really "hex" per se. https://github.com/arduino/Arduino/pull/2567/files#diff-3f519593b982008c8fefa0d4a62300c4L72 That's the reason I used hex in the keys. |
|
Yes, please, let's name the recipe output instead of hex. You're right about the fact that the inconsistency should be fixed in the objcopy recipe too, it makes no sense to hardcode the .hex extension there. We'll fix that with another pull request BTW. |
|
@cmaglie done :) |
cmaglie
added
Component: IDE
| File hexFile = new File(prefs.get("build.path") + "/" + tmp_file); | ||
| File saveFile = new File(sketch.getFolder().getAbsolutePath() + "/" + save_file); | ||
|
|
||
| FileReader in = new FileReader(hexFile); |
There was a problem hiding this comment.
FileUtils.copyFile may be used here.
|
@championswimmer can you update the code so that it merges again? |
|
Oh shit, had forgotten about this totally. Will do that Arnav Gupta (championswimmer) On 3 March 2015 at 18:56, Federico Fissore notifications@github.com wrote:
|
* Moving Upload options from "File" menu to "Sketch" menu as those
are sketch actions more than file actions.
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
championswimmer
force-pushed
the
ide-1.5.x-saveHex
branch
from
6939202 to
c28ea8c
Compare
|
Hey, what's the status on this? |
are sketch actions more than file actions.
Signed-off-by: Arnav Gupta championswimmer@gmail.com