Skip to content

add save when verifyng and uploading (round 2) #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2014

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 9, 2014

As discussed on #2214:

  • Disable auto-save if the sketch is read-only (i.e. on examples) as suggested by @agdl and @GregWoods
  • Fix spelling and minor adjustment on commits as suggested by @matthijskooijman

This pull request close #1934

@cmaglie cmaglie added this to the Release 1.5.9 milestone Nov 9, 2014
@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Component: IDE The Arduino IDE labels Nov 9, 2014
@cmaglie cmaglie self-assigned this Nov 9, 2014
@matthijskooijman
Copy link
Collaborator

Looks good to me.

@JulyJim
Copy link

JulyJim commented Nov 10, 2014

A small notes - it is not clear if "save and compile" was really implemented, but that is not what my comment about.
My current project (on Due) takes 7% of memory and it still takes almost 2 minutes ( on an average ) to fully or partially ( not compiling what did not change) compile.
The "...things changed, compiling all"( not a quote) message SELDOM appears and is followed by "pregnant pause" for almost a minute when nothing gets printed in "progress window".
So if you add "save and compile" it MAY look even more goofy - or is it a Unix -"all OK no response " way?
I feel auto save would be in line with some of the Arduino " do this automatically for newbies benefits" which is many cases ( function prototyping) tries to "do better " than language standards.

@matthijskooijman
Copy link
Collaborator

@VaclavSal, Not sure how this is relevant to his PR? When you have verbose compilation is disabled, no compiler output is shown, so you'll have to wait until everything is compiled before you see the result. If you think this is a problem, perhaps you should open a separate issue for it?

As for the "automatically for newbies" thing, this adds an option for autosave, so if it does not fit your workflow, you can just disable it?

@cmaglie cmaglie merged commit 9a9fef8 into arduino:ide-1.5.x Nov 13, 2014
@cmaglie cmaglie deleted the autosave branch November 13, 2014 10:55
@cmaglie cmaglie mentioned this pull request Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants