Stream - virtual copy constructor added

[timschneider]

I've added a virtual copy constructor to Stream.h / .cpp, to give the user the ability to pass derived classes as reference.

Tim

[lestofante]

I like this, hope to see it in mainstream soon

2012/10/9 timschneider notifications@github.com

I added a virtual copy constructor to Stream.h / .cpp, to give the user
the ability to pass derived classes as reference.

Tim

You can merge this Pull Request by running:

git pull https://github.com/timschneider/Arduino patch-1

Or view, comment on, or merge it at:

#119
Commit Summary

• Copy Constructor Stream& operator=(Stream& src) added.
• Virtual Copy Constructor Stream& operator=(Stream& src) added.

File Changes

• M hardware/arduino/cores/arduino/Stream.cpp (9)
• M hardware/arduino/cores/arduino/Stream.h (1)

Patch Links

• https://github.com/arduino/Arduino/pull/119.patch

• https://github.com/arduino/Arduino/pull/119.diff

  —
  Reply to this email directly or view it on GitHubhttps://github.com/Stream - virtual copy constructor added #119.

[mbanzi]

hello timschneider can you show me and example of how this would change things for end users? what does it allow you to do?

[timschneider]

I used it in the following way.

the firmata arduino library uses a serial stream for communication with the host application on the pc. I've built an arduino http server with websocket support and moved the host application onto the arduino mega board. To be conform to the Firmata library, I'm using a custom memory stream which is created for every websocket client at runtime. For that reason i've to change the stream at runtime, but when you try this with just a reference it wont work otherwise you have to use pointers or like i did, with a virtual copy constructor.

The enduser has the benefit to change stream references at runtime over different class types.

Let me say i've a class called TerminalServer with a property of the type Stream& MyStream. But u change the Stream at Runtime from EthernetStream to SerialStream or BluetoothStream, all have Stream as parent, now u have the ability to do this.

Tim

[soundanalogous]

This issue should be closed. This was fixed via a different means in Firmata v2.3.6.

[cmaglie]

@soundanalogous
thanks for the heads up!