Add rts dtr and baudrate public functions in CDC Serial_ class #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permit to use the CDC serial link like a modem. For example configuration mode while DTR is low and data mode otherwise. Signed-off-by: Stany MARCEL <stanypub@gmail.com>
|
Can I build this pull request? |
|
Yes I think so, I can't see any reason it should not work. |
|
@ynsta sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE |
|
Code looks good to me. I don't think we can really make this API generic, so just adding it in |
|
"ynsta commented on 19 Dec 2012" |
NicoHood
pushed a commit
to NicoHood/HID
that referenced
this pull request
Dec 9, 2014
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
cmaglie
added
Component: Core
facchinm
added
the
USB: CDC serial
|
Fixed with 96f7b96 |
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
arduino/Arduino#2469 Weak implementation sounds usefull but takes 6 more bytes of flash/ function (12). Even more, if we would also pass the line states but the user can read this with Serial.dtr() for example. arduino/Arduino#1179 Should we inline the Serial.dtr() functuions etc? But then we need to move the line info to the header as well, also the definition. These optional functions only take flash if they are used. Virtual isnt used, because this would take more flash for no reason. Syntax like this: https://www.pjrc.com/teensy/td_serial.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permit to use the CDC serial link like a modem. For example configuration
mode while DTR is low and data mode otherwise.
Signed-off-by: Stany MARCEL stanypub@gmail.com