Skip to content

New Serial.begin(baud, config); #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2012
Merged

New Serial.begin(baud, config); #109

merged 8 commits into from
Aug 30, 2012

Conversation

Alarus
Copy link
Contributor

@Alarus Alarus commented Aug 14, 2012

Adding advanced begin (baud, config). The function sets the number of bits, parity, stop bits.

Alarus added 8 commits August 12, 2012 20:18
Adding advanced begin (); with the ability to specify the length of bits, parity, stop bits.
Adding advanced begin (); with the ability to specify the length of bits, parity, stop bits.
Adding advanced begin (); with the ability to specify the length of bits, parity, stop bits.
Adding advanced begin (); with the ability to specify the length of bits, parity, stop bits.
Adding advanced begin (); with the ability to specify the length of bits, parity, stop bits.
damellis added a commit that referenced this pull request Aug 30, 2012
Serial.begin() parameter to set data bits, parity, stop bits.
@damellis damellis merged commit a72d05b into arduino:master Aug 30, 2012
@damellis
Copy link
Contributor

I merged this and also made a couple of tweaks:

a72d05b
ae9b906
a374e8b

The first tweak was renaming the constants to better match the Arduino style.

The other tweak involved modifying the way that the bits are actually set. It's possible I got it wrong, so please look it over and try it out. In particular, I'm now only setting the high (0x80) bit on the ATmega8 (where you need it to write to UCSRC instead of UBBRH) but not on the other processors, where it selects a reserved value for the UART mode. Also, I'm no longer bitwise-on the config parameter with the existing UCSRC register value since we want to actually set all of the options in the register.

Anyone see any problems or have suggestions for further changes?

@Alarus
Copy link
Contributor Author

Alarus commented Sep 1, 2012

All right. Very good solution.

oriregev pushed a commit to oriregev/Arduino that referenced this pull request Dec 20, 2013
Serial.begin() parameter to set data bits, parity, stop bits.
tbowmo pushed a commit to tbowmo/Arduino that referenced this pull request Jul 14, 2016
Add LEDs blinking into base MySensor class without any library dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants