Repo cleanup #10166
Merged
Repo cleanup #10166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the repository root a bit cleaner. Since these files are used automatically and are not intended to be directly read by users, there is no point in keeping them in the root (github will pick up these templates from the root, .github directory or docs directory equally).
It seems this script was used to extract libraries, along with their history, from the libraries directory of this repository. Since then, all libraries have been extracted and then deleted in commit 067d7e9 (Delete builtin libraries sources), so no need to keep this script around.
In commit 067d7e9 (Delete builtin libraries sources) all the libraries in there were removed, since they are all now automatically downloaded during the build. To keep the repository clean, remove the empty directory as well as the build rule that was used to copy libraries from this (now empty) directory into the build result.
matthijskooijman
force-pushed
the
repo-cleanup
branch
2 times, most recently
from
9eb1647 to
a801cdb
Compare
matthijskooijman
force-pushed
the
repo-cleanup
branch
from
a801cdb to
7fa733d
Compare
|
✅ Build completed. Please test this code using one of the following: ⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10166-BUILD-956-linux32.tar.xz ℹ️ The |
|
Force pushed some more fixes to the README formatting, pointed out by the codacy check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking for a place to document how to run tests, I noticed there were some files and directories in the repository root that do not really need to be there. This PR (re)moves them, resulting in a cleaner repository.
Also, I decided to document the test process on the wiki, so I added a note to the README that points there (which is a bit off-topic for this PR, but since I also wanted to add some other links to the README, I included that commit in here as well).
Also, maybe we should remove the
hardwarefolder too, but I did not do that yet. It currently contains:package_index_bundled.jsonfile, which describes the bundled AVR core. I wonder if that should not really be tracked as part of the ArduinoCore-avr repo (but that might be a fundamental discussion about the relation between these json files and platform.txt). Alternatively, this file could maybe be moved intobuild/somewhere, though I did really try to come up with a good place.