-
-
Notifications
You must be signed in to change notification settings - Fork 7k
No indent for namespace with auto format #6812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just a note that it is possible to customize the auto format configuration:
You can find documentation of all the configuration options here: That's not to say that it isn't reasonable to request that this be set by default, but only to make it clear that we do each have the option to configure the formatter to our own preferences if the defaults are not to our liking. |
@per1234 Thank you, that worked. If you want this to be the default, and point me in the right direction I can start working on a pull request... |
At a glance it does seem sensible to indent. I tend to just accept whatever style conventions were originally set for the formatter but I don't know whether that option was intentionally left out or just never considered. It's somewhat unfortunate to change the established standards but I don't think this change would have a huge impact since it's not very common to see namespaces used in Arduino sketches. It's certainly better to make the change now rather than later if it's going to be done. If you want to submit a pull request the file is here: https://github.com/arduino/Arduino/blob/master/build/shared/lib/formatter.conf |
As said in #6813 we will never find a configuration that match everyone's personal taste, so I'll close this as wontfix and just keep the existing configuration. |
after running auto format (Ctrl+T) becomes
To me, this seems like incorrect formatting.
The text was updated successfully, but these errors were encountered: