Skip to content

RW pin not correctly disabled in LiquidCrystal library. [imported] #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmaglie opened this issue Nov 15, 2012 · 0 comments
Closed

RW pin not correctly disabled in LiquidCrystal library. [imported] #136

cmaglie opened this issue Nov 15, 2012 · 0 comments

Comments

@cmaglie
Copy link
Member

cmaglie commented Nov 15, 2012

This is Issue 136 moved from a Google Code project.
Added by 2009-10-30T06:45:24.000Z by dmel...@gmail.com.
Please review that bug for more context and additional comments, but update this bug.
Closed (Fixed).

Original labels: Type-Defect, Priority-Medium, Component-Core, Milestone-0018

Original description

"As _rw_pin is defined as unsigned, it can never take the value -1 (it has the value 255) and the
compiler optimises out the 'if' and so LOW gets written to port 255.

"Changing the type of _rw_pin to int8_t fixes the problem."

http://www.arduino.cc/cgi-bin/yabb2/YaBB.pl?num=1256839192
@cmaglie cmaglie closed this as completed Nov 15, 2012
tbowmo pushed a commit to tbowmo/Arduino that referenced this issue Jul 14, 2016
@henrikekblad
Merge pull request arduino#136 from Yveaux/master
945c7f4 
Allow disabling of LED/Inclusion pins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmaglie