Skip to content

Commit 2a401f2

Browse files
committed
"Add library" moved into "Import library" menu
1 parent 3e9ef44 commit 2a401f2

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

app/src/processing/app/Base.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -954,8 +954,18 @@ public Map<String, File> getUserLibs() {
954954
return userLibs;
955955
}
956956

957-
public void rebuildImportMenu(JMenu importMenu) {
957+
public void rebuildImportMenu(JMenu importMenu, final Editor editor) {
958958
importMenu.removeAll();
959+
960+
JMenuItem addLibraryMenuItem = new JMenuItem(_("Add Library..."));
961+
addLibraryMenuItem.addActionListener(new ActionListener() {
962+
public void actionPerformed(ActionEvent e) {
963+
Base.this.handleAddLibrary(editor);
964+
Base.this.onBoardOrPortChange();
965+
Base.this.rebuildImportMenu(Editor.importMenu, editor);
966+
}
967+
});
968+
importMenu.add(addLibraryMenuItem);
959969

960970
// Split between user supplied libraries and IDE libraries
961971
Map<String, File> ideLibs = getIDELibs();
@@ -1108,7 +1118,7 @@ public void onBoardOrPortChange() {
11081118
}
11091119

11101120

1111-
public void rebuildBoardsMenu(JMenu boardsMenu, final JMenu cpuTypeMenu) {
1121+
public void rebuildBoardsMenu(JMenu boardsMenu, final JMenu cpuTypeMenu, final Editor editor) {
11121122
String selPackage = Preferences.get("target_package");
11131123
String selPlatform = Preferences.get("target_platform");
11141124
String selBoard = Preferences.get("board");
@@ -1172,7 +1182,7 @@ public void actionPerformed(ActionEvent actionevent) {
11721182

11731183
onBoardOrPortChange();
11741184
Sketch.buildSettingChanged();
1175-
rebuildImportMenu(Editor.importMenu);
1185+
rebuildImportMenu(Editor.importMenu, editor);
11761186
rebuildExamplesMenu(Editor.examplesMenu);
11771187
}
11781188
};

app/src/processing/app/Editor.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -630,20 +630,10 @@ public void actionPerformed(ActionEvent e) {
630630

631631
if (importMenu == null) {
632632
importMenu = new JMenu(_("Import Library..."));
633-
base.rebuildImportMenu(importMenu);
633+
base.rebuildImportMenu(importMenu, this);
634634
}
635635
sketchMenu.add(importMenu);
636636

637-
item = new JMenuItem(_("Add Library..."));
638-
item.addActionListener(new ActionListener() {
639-
public void actionPerformed(ActionEvent e) {
640-
base.handleAddLibrary(Editor.this);
641-
base.onBoardOrPortChange();
642-
base.rebuildImportMenu(Editor.importMenu);
643-
}
644-
});
645-
sketchMenu.add(item);
646-
647637
item = newJMenuItem(_("Show Sketch Folder"), 'K');
648638
item.addActionListener(new ActionListener() {
649639
public void actionPerformed(ActionEvent e) {
@@ -694,10 +684,10 @@ public void actionPerformed(ActionEvent e) {
694684
if (boardsMenu == null) {
695685
boardsMenu = new JMenu(_("Board"));
696686
cpuTypeMenu = new JMenu(_("Processor"));
697-
base.rebuildBoardsMenu(boardsMenu, cpuTypeMenu);
687+
base.rebuildBoardsMenu(boardsMenu, cpuTypeMenu, this);
698688
//Debug: rebuild imports
699689
importMenu.removeAll();
700-
base.rebuildImportMenu(importMenu);
690+
base.rebuildImportMenu(importMenu, this);
701691
}
702692
menu.add(boardsMenu);
703693
menu.add(cpuTypeMenu);

0 commit comments

Comments
 (0)