test: reduce PowerMock usage for code coverage (#7452)

JaCoCo used for code coverage calculation in the project doesn't support PowerMockito classes.
This PR attemps to reduce usage of PowerMockito.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

api/src/test/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmdTest.java

@@ -17,26 +17,27 @@
 
 package org.apache.cloudstack.api.command.user.network;
 
-import com.cloud.exception.InsufficientCapacityException;
-import com.cloud.exception.ResourceAllocationException;
-import com.cloud.network.Network;
-import com.cloud.network.NetworkService;
-import com.cloud.offering.NetworkOffering;
-import com.cloud.utils.db.EntityManager;
-import junit.framework.TestCase;
 import org.apache.cloudstack.api.ResponseGenerator;
 import org.apache.cloudstack.api.ResponseObject;
 import org.apache.cloudstack.api.response.NetworkResponse;
 import org.junit.Assert;
+import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.Mockito;
-import org.powermock.modules.junit4.PowerMockRunner;
+import org.mockito.junit.MockitoJUnitRunner;
 import org.springframework.test.util.ReflectionTestUtils;
 
-@RunWith(PowerMockRunner.class)
-public class CreateNetworkCmdTest extends TestCase {
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.network.Network;
+import com.cloud.network.NetworkService;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.utils.db.EntityManager;
+
+@RunWith(MockitoJUnitRunner.class)
+public class CreateNetworkCmdTest {
 
     @Mock
     public EntityManager _entityMgr;
@@ -46,139 +47,161 @@ public class CreateNetworkCmdTest extends TestCase {
 
     @InjectMocks
     CreateNetworkCmd cmd = new CreateNetworkCmd();
+
+    @Test
     public void testGetNetworkOfferingId() {
         Long networkOfferingId = 1L;
         ReflectionTestUtils.setField(cmd, "networkOfferingId", networkOfferingId);
         Assert.assertEquals(cmd.getNetworkOfferingId(), networkOfferingId);
     }
 
+    @Test
     public void testGetGateway() {
         String gateway = "10.10.10.1";
         ReflectionTestUtils.setField(cmd, "gateway", gateway);
         Assert.assertEquals(cmd.getGateway(), gateway);
     }
 
+    @Test
     public void testGetIsolatedPvlan() {
         String isolatedPvlan = "1234";
         ReflectionTestUtils.setField(cmd, "isolatedPvlan", isolatedPvlan);
         Assert.assertEquals(cmd.getIsolatedPvlan(), isolatedPvlan);
     }
 
+    @Test
     public void testGetAccountName() {
         String accountName = "admin";
         ReflectionTestUtils.setField(cmd, "accountName", accountName);
         Assert.assertEquals(cmd.getAccountName(), accountName);
     }
 
+    @Test
     public void testGetDomainId() {
         Long domainId = 1L;
         ReflectionTestUtils.setField(cmd, "domainId", domainId);
         Assert.assertEquals(cmd.getDomainId(), domainId);
     }
 
+    @Test
     public void testGetNetmask() {
         String netmask = "255.255.255.0";
         ReflectionTestUtils.setField(cmd, "netmask", netmask);
         Assert.assertEquals(cmd.getNetmask(), netmask);
     }
 
+    @Test
     public void testGetStartIp() {
         String startIp = "10.10.10.2";
         ReflectionTestUtils.setField(cmd, "startIp", startIp);
         Assert.assertEquals(cmd.getStartIp(), startIp);
     }
 
+    @Test
     public void testGetEndIp() {
         String endIp = "10.10.10.10";
         ReflectionTestUtils.setField(cmd, "endIp", endIp);
         Assert.assertEquals(cmd.getEndIp(), endIp);
     }
 
+    @Test
     public void testGetNetworkName() {
         String netName = "net-isolated";
         ReflectionTestUtils.setField(cmd, "name", netName);
         Assert.assertEquals(cmd.getNetworkName(), netName);
     }
 
+    @Test
     public void testGetDisplayTextWhenNotEmpty() {
         String description = "Isolated Network";
         ReflectionTestUtils.setField(cmd, "displayText", description);
         Assert.assertEquals(cmd.getDisplayText(), description);
     }
 
+    @Test
     public void testGetDisplayTextWhenEmpty() {
         String description = null;
         String netName = "net-isolated";
         ReflectionTestUtils.setField(cmd, "name", netName);
         Assert.assertEquals(cmd.getDisplayText(), netName);
     }
 
+    @Test
     public void testGetNetworkDomain() {
         String netDomain = "cs1cloud.internal";
         ReflectionTestUtils.setField(cmd, "networkDomain", netDomain);
         Assert.assertEquals(cmd.getNetworkDomain(), netDomain);
     }
 
+    @Test
     public void testGetProjectId() {
         Long projectId = 1L;
         ReflectionTestUtils.setField(cmd, "projectId", projectId);
         Assert.assertEquals(cmd.getProjectId(), projectId);
     }
 
+    @Test
     public void testGetAclType() {
         String aclType = "account";
         ReflectionTestUtils.setField(cmd, "aclType", aclType);
         Assert.assertEquals(cmd.getAclType(), aclType);
     }
 
+    @Test
     public void testGetSubdomainAccess() {
         Boolean subDomAccess = false;
         ReflectionTestUtils.setField(cmd, "subdomainAccess", subDomAccess);
         Assert.assertEquals(cmd.getSubdomainAccess(), subDomAccess);
     }
 
+    @Test
     public void testGetVpcId() {
         Long vpcId = 1L;
         ReflectionTestUtils.setField(cmd, "vpcId", vpcId);
         Assert.assertEquals(cmd.getVpcId(), vpcId);
     }
 
+    @Test
     public void testGetDisplayNetwork() {
         Boolean displayNet = true;
         ReflectionTestUtils.setField(cmd, "displayNetwork", displayNet);
         Assert.assertEquals(cmd.getDisplayNetwork(), displayNet);
     }
 
+    @Test
     public void testGetExternalId() {
         String externalId = "1";
         ReflectionTestUtils.setField(cmd, "externalId", externalId);
         Assert.assertEquals(cmd.getExternalId(), externalId);
     }
 
+    @Test
     public void testGetAssociatedNetworkId() {
         Long associatedNetId = 1L;
         ReflectionTestUtils.setField(cmd, "associatedNetworkId", associatedNetId);
         Assert.assertEquals(cmd.getAssociatedNetworkId(), associatedNetId);
     }
 
+    @Test
     public void testIsDisplayNullDefaultsToTrue() {
         Boolean displayNetwork = null;
         ReflectionTestUtils.setField(cmd, "displayNetwork", displayNetwork);
         Assert.assertTrue(cmd.isDisplay());
     }
 
+    @Test
     public void testGetPhysicalNetworkIdForInvalidNetOfferingId() {
         Long physicalNetworkId = 1L;
 
         ReflectionTestUtils.setField(cmd, "physicalNetworkId", physicalNetworkId);
-        Mockito.when(_entityMgr.findById(NetworkOffering.class, 1L)).thenReturn(null);
         try {
             cmd.getPhysicalNetworkId();
         } catch (Exception e) {
             Assert.assertTrue(e.getMessage().startsWith("Unable to find network offering by ID"));
         }
     }
 
+    @Test
     public void testGetPhysicalNetworkIdForInvalidAssociatedNetId() {
         Long physicalNetworkId = 1L;
         Long networkOfferingId = 1L;
@@ -196,6 +219,7 @@ public void testGetPhysicalNetworkIdForInvalidAssociatedNetId() {
         }
     }
 
+    @Test
     public void testGetPhysicalNetworkIdForAssociatedNetIdForNonSharedNet() {
         Long physicalNetworkId = 1L;
         Long networkOfferingId = 1L;
@@ -215,6 +239,7 @@ public void testGetPhysicalNetworkIdForAssociatedNetIdForNonSharedNet() {
         }
     }
 
+    @Test
     public void testGetPhysicalNetworkIdForNonSharedNet() {
         Long physicalNetworkId = 1L;
         Long networkOfferingId = 1L;
@@ -230,6 +255,7 @@ public void testGetPhysicalNetworkIdForNonSharedNet() {
         }
     }
 
+    @Test
     public void testGetPhysicalNetworkIdForSharedNet() {
         Long physicalNetworkId = 1L;
         Long networkOfferingId = 1L;
@@ -245,6 +271,7 @@ public void testGetPhysicalNetworkIdForSharedNet() {
         }
     }
 
+    @Test
     public void testGetZoneId() {
         Long physicalNetworkId = 1L;
         Long networkOfferingId = 1L;
@@ -258,30 +285,35 @@ public void testGetZoneId() {
         Assert.assertEquals(cmd.getZoneId(), zoneId);
     }
 
+    @Test
     public void testGetPublicMtuWhenNotSet() {
         Integer publicMtu = null;
         ReflectionTestUtils.setField(cmd, "publicMtu", publicMtu);
         Assert.assertEquals(NetworkService.DEFAULT_MTU, cmd.getPublicMtu());
     }
 
+    @Test
     public void testGetPublicMtuWhenSet() {
         Integer publicMtu = 1450;
         ReflectionTestUtils.setField(cmd, "publicMtu", publicMtu);
         Assert.assertEquals(cmd.getPublicMtu(), publicMtu);
     }
 
+    @Test
     public void testGetPrivateMtuWhenNotSet() {
         Integer privateMtu = null;
         ReflectionTestUtils.setField(cmd, "privateMtu", privateMtu);
         Assert.assertEquals(NetworkService.DEFAULT_MTU, cmd.getPrivateMtu());
     }
 
+    @Test
     public void testGetPrivateMtuWhenSet() {
         Integer privateMtu = 1250;
         ReflectionTestUtils.setField(cmd, "privateMtu", privateMtu);
         Assert.assertEquals(cmd.getPrivateMtu(), privateMtu);
     }
 
+    @Test
     public void testExecute() throws InsufficientCapacityException, ResourceAllocationException {
         ReflectionTestUtils.setField(cmd, "displayText", "testNetwork");
         ReflectionTestUtils.setField(cmd, "name", "testNetwork");