perf(@angular/cli): fix unnecessary esbuild rebuilds #30234
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
bot
added
area: performance
clydin
reviewed
May 2, 2025
When using esbuild, Angular sets up a custom file watcher using esbuilds metafile inputs. Esbuild will generate <define:KEY> entries see https://esbuild.github.io/try/#YgAwLjI1LjMALS1kZWZpbmU6Rk9PPSd7fScgLS1tZXRhZmlsZSAtLWJ1bmRsZQBlAGVudHJ5LmpzAGNvbnNvbGUubG9nKEZPTyk. After the build is finished, the file watcher will notice that the <define:KEY> entries no longer exist on the file system and trigger a rebuild even though no files have changed. This change, fixes the above issue by filtering files starting with `<define:`.
sirTomasson
force-pushed
the
perf-unnecessary-esbuld-rebuilds
branch
from
b4bfb44 to
85dc594
Compare
|
I changed the scope to |
jkrems
approved these changes
May 3, 2025
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using esbuild, Angular sets up a custom file watcher using esbuilds metafile inputs. Esbuild will generate define:KEY entries see https://esbuild.github.io/try/#YgAwLjI1LjMALS1kZWZpbmU6Rk9PPSd7fScgLS1tZXRhZmlsZSAtLWJ1bmRsZQBlAGVudHJ5LmpzAGNvbnNvbGUubG9nKEZPTyk. After the build is finished, the file watcher will notice that the define:KEY entries no longer exist on the file system and trigger a rebuild even though no files have changed.
Issue Number: N/A
What is the new behavior?
No rebuilds are triggered since the file watcher is no longer tracking changes to define:KEY entries.
Does this PR introduce a breaking change?
Other information
There other conditions which may also trigger a rebuilds, because the file watcher is tracking all inputs from the metafile, which are not necessarily files. This esbuild plugin example will also trigger a rebuild because esbuild will add the
ns-envnamespace to the metafile inputs.