Skip to content

fix(@schematics/angular): generate interceptors with a dash type separator #30049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 7, 2025

To align with the updated style guide, Angular v20 will generate interceptors with file extension interceptor type prefixed with a - separator instead of a . by default. Projects will automatically use this naming convention. Projects can however opt-out by setting the typeSeparator option to . for the interceptor schematic. This can be done as a default in the angular.json or directly on the commandline via --type-separator=. when executing ng generate. As an example, example.interceptor.ts will now be named example-interceptor.ts. The TypeScript declaration will continue to contain Interceptor such as with ExampleInterceptor.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 7, 2025
…rator

To align with the updated style guide, Angular v20 will generate interceptors
with file extension `interceptor` type prefixed with a `-` separator instead of
a `.` by default. Projects will automatically use this naming convention.
Projects can however opt-out by setting the `typeSeparator` option to `.`
for the interceptor schematic. This can be done as a default in the `angular.json`
or directly on the commandline via `--type-separator=.` when executing `ng generate`.
As an example, `example.interceptor.ts` will now be named `example-interceptor.ts`.
The TypeScript declaration will continue to contain `Interceptor` such as with `ExampleInterceptor`.
@clydin clydin force-pushed the style-guide/interceptors branch from ae07dd3 to 83964c6 Compare April 7, 2025 15:44
@clydin clydin requested a review from alan-agius4 April 7, 2025 16:21
@clydin clydin marked this pull request as ready for review April 7, 2025 16:21
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 7, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 7, 2025
@clydin clydin merged commit 040282d into angular:main Apr 7, 2025
33 checks passed
@clydin clydin deleted the style-guide/interceptors branch April 7, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants