Skip to content

refactor(@schematics/angular): use generateFromFiles helper in even more cases #30030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 4, 2025

The enum, interceptor, and resolver schematics now more fully use the generateFromFiles helper. This reduces repeat code within each schematic. In some cases the schematic has been reduced to a single call to the helper.

… more cases

The enum, interceptor, and resolver schematics now more fully
use the `generateFromFiles` helper.  This reduces repeat code within each
schematic. In some cases the schematic has been reduced to a single call
to the helper.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 4, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2025
@clydin clydin requested a review from alan-agius4 April 4, 2025 18:14
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 7, 2025
@clydin clydin merged commit df85980 into angular:main Apr 7, 2025
34 checks passed
@clydin clydin deleted the schematics/cleanup-generated-from-files branch April 7, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants