Skip to content

@schematics/angular: ng new generated app has no icons #26257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
fmalcher opened this issue Nov 7, 2023 · 2 comments · Fixed by #26259
Closed
1 task

@schematics/angular: ng new generated app has no icons #26257

fmalcher opened this issue Nov 7, 2023 · 2 comments · Fixed by #26259
Assignees
@alan-agius4
Labels
area: @schematics/angular freq3: high severity3: broken type: bug/fix

Comments

@fmalcher
Copy link
Contributor

fmalcher commented Nov 7, 2023 •
edited
Loading

Command

new

Is this a regression?

  • Yes, this behavior used to work in the previous version

Description

The new buttons are intended to show an icon, but they just show the icon text.

Screenshot 2023-11-07 at 10 49 06

Minimal Reproduction

npx -p @angular/cli@next ng new book-rating --standalone --routing --style=scss --no-ssr

Your Environment

Angular 17.0.0-rc.4
@fmalcher
Copy link
Contributor Author

fmalcher commented Nov 7, 2023 •
edited
Loading

Do you actually want to include Material icons in the clean app?
I'd rather like to have an inline SVG there as for the other icons. That way we can easily remove the sample page without touching too many files or dependencies.
@dgp1130

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @schematics/angular freq3: high and removed freq1: low Only reported by a handful of users who observe it rarely labels Nov 7, 2023
@alan-agius4 alan-agius4 self-assigned this Nov 7, 2023
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
acd8d9d 
This commit adds a number of missing icons.

Closes angular#26257
@alan-agius4 alan-agius4 mentioned this issue Nov 7, 2023
Merged
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
80ce09e 
This commit adds a number of missing icons.

Closes angular#26257
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
d9f9dfe 
This commit adds a number of missing icons.

Closes angular#26257
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
0eb010a 
This commit adds a number of missing icons.

Closes angular#26257
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
a47fed3 
This commit adds a number of missing icons.

Closes angular#26257
alan-agius4 added a commit that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
1f02aa9 
This commit adds a number of missing icons.

Closes #26257
alan-agius4 added a commit that referenced this issue Nov 7, 2023
@alan-agius4
fix(@schematics/angular): add missing icons in ng-new template
ecdcff2 
This commit adds a number of missing icons.

Closes #26257

(cherry picked from commit 1f02aa9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: @schematics/angular freq3: high severity3: broken type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@schematics/angular): add missing icons in ng-new template alan-agius4/angular-cli
2 participants
@fmalcher @alan-agius4