Skip to content

.angular cache folder not ignored after ng update to v13 #21969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Assignees
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone

Comments

@fmalcher
Copy link
Contributor

fmalcher commented Oct 18, 2021

🐞 Bug report

Command (mark with an x)

  • update

Is this a regression?

Yes, the previous version in which this bug was not present was: 12.2.10

Description

Newly created projects with 13.0.0-rc.0 have the .angular cache folder added to .gitignore.
When updating from a v12.2.10 project, the entry is not added, hence the folder is not ignored.

🔬 Minimal Reproduction

# create new project with globally installed CLI 13.0.0-rc.0
ng new foofoo --routing=false --style=css

=> ✅ has /.angular/cache in .gitignore

# create new project with globally installed CLI 12.2.10
ng new foofoo --routing=false --style=css
cd foofoo

# update to 13.0.0-rc.0
ng update @angular/cli --next

=> ❌ does NOT have /.angular cache folder ignored!

🌍 Your Environment


Angular CLI: 13.0.0-rc.0
Node: 14.17.6
Package Manager: npm 6.14.15
OS: darwin x64

Angular: 13.0.0-rc.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
@fmalcher fmalcher changed the title .angular cache folder not ignored after ng update .angular cache folder not ignored after ng update to v13 Oct 18, 2021
@ngbot ngbot bot added this to the needsTriage milestone Oct 18, 2021
@alan-agius4 alan-agius4 self-assigned this Oct 18, 2021
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity3: broken labels Oct 18, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 18, 2021
clydin pushed a commit that referenced this issue Oct 18, 2021
…elease

With this change we fix an issue were migrations are not run when the version specified in migration collection is specified as stable example `13.0.0`, but the version specified in the `package.json` is still a prerelease example `13.0.0-rc.0`.

Closes: #21969
clydin pushed a commit that referenced this issue Oct 18, 2021
…elease

With this change we fix an issue were migrations are not run when the version specified in migration collection is specified as stable example `13.0.0`, but the version specified in the `package.json` is still a prerelease example `13.0.0-rc.0`.

Closes: #21969
(cherry picked from commit ebf2d62)
clydin pushed a commit that referenced this issue Oct 18, 2021
…elease

With this change we fix an issue were migrations are not run when the version specified in migration collection is specified as stable example `13.0.0`, but the version specified in the `package.json` is still a prerelease example `13.0.0-rc.0`.

Closes: #21969
(cherry picked from commit ebf2d62)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.