Skip to content

Commit cf1b778

Browse files
committed
fix(@angular-devkit/core): update logger forEach promiseCtor type
`typeof Promise` and `PromiseConstructorLike` are not the same thing. This causes issues in G3 when `strictNullChecks` are being enabled using RXJS 7.
1 parent 1cd53d6 commit cf1b778

File tree

2 files changed

+5
-2
lines changed
  • goldens/public-api/angular_devkit/core
  • packages/angular_devkit/core/src/logger

2 files changed

+5
-2
lines changed

goldens/public-api/angular_devkit/core/index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ class Logger extends Observable<LogEntry> implements LoggerApi {
459459
// (undocumented)
460460
fatal(message: string, metadata?: JsonObject): void;
461461
// (undocumented)
462-
forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void>;
462+
forEach(next: (value: LogEntry) => void, promiseCtor?: PromiseConstructorLike): Promise<void>;
463463
// (undocumented)
464464
info(message: string, metadata?: JsonObject): void;
465465
// (undocumented)

packages/angular_devkit/core/src/logger/logger.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
162162
);
163163
}
164164

165-
override forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void> {
165+
override forEach(
166+
next: (value: LogEntry) => void,
167+
promiseCtor?: PromiseConstructorLike,
168+
): Promise<void> {
166169
return this._observable.forEach(next, promiseCtor);
167170
}
168171
}

0 commit comments

Comments
 (0)