Skip to content

Commit bf7ed0d

Browse files
committed
ci: correct analytics validation script to print user custom dimensions
Prior to this user custom dimensions were not added to `docs/design/analytics.md`
1 parent 2fb9a4d commit bf7ed0d

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

docs/design/analytics.md

+8-11
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ PROJECT NAME TO BUILD OR A MODULE NAME.**
3838
<!--USER_DIMENSIONS_TABLE_BEGIN-->
3939
| Name | Parameter | Type |
4040
|:---:|:---|:---|
41-
| Command | `ep.ng_command` | `string` |
42-
| SchematicCollectionName | `ep.ng_schematic_collection_name` | `string` |
43-
| SchematicName | `ep.ng_schematic_name` | `string` |
44-
| Standalone | `ep.ng_standalone` | `string` |
45-
| Style | `ep.ng_style` | `string` |
46-
| Routing | `ep.ng_routing` | `string` |
47-
| InlineTemplate | `ep.ng_inline_template` | `string` |
48-
| InlineStyle | `ep.ng_inline_style` | `string` |
49-
| BuilderTarget | `ep.ng_builder_target` | `string` |
50-
| Aot | `ep.ng_aot` | `string` |
51-
| Optimization | `ep.ng_optimization` | `string` |
41+
| OsArchitecture | `up.ng_os_architecture` | `string` |
42+
| NodeVersion | `up.ng_node_version` | `string` |
43+
| NodeMajorVersion | `upn.ng_node_major_version` | `number` |
44+
| AngularCLIVersion | `up.ng_cli_version` | `string` |
45+
| AngularCLIMajorVersion | `upn.ng_cli_major_version` | `number` |
46+
| PackageManager | `up.ng_package_manager` | `string` |
47+
| PackageManagerVersion | `up.ng_package_manager_version` | `string` |
48+
| PackageManagerMajorVersion | `upn.ng_package_manager_major_version` | `number` |
5249
<!--USER_DIMENSIONS_TABLE_END-->
5350

5451
### List of Event Custom Dimensions

scripts/validate-user-analytics.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ const metricsTableRe = /<!--METRICS_TABLE_BEGIN-->([\s\S]*)<!--METRICS_TABLE_END
2828

2929
async function _checkUserDimensions(dimensionsTable: string, logger: logging.Logger) {
3030
logger.info('Gathering user dimensions from @angular/cli...');
31-
const eventCustomDimensionValues = new Set(Object.values(UserCustomDimension));
32-
33-
const data = Object.entries(EventCustomDimension).map(([key, value]) => ({
31+
const data = Object.entries(UserCustomDimension).map(([key, value]) => ({
3432
parameter: value,
3533
name: key,
3634
type: value.charAt(2) === 'n' ? 'number' : 'string',

0 commit comments

Comments
 (0)