Skip to content

Commit 9effb24

Browse files
CaerusKarualan-agius4
authored andcommitted
build: remove dev dependency on @types/express-serve-static-core
@types/express-serve-static-core is now a direct dependency of @types/express, and having both creates TypeScript conflicts.
1 parent fc3d184 commit 9effb24

File tree

4 files changed

+2
-14
lines changed

4 files changed

+2
-14
lines changed

modules/express-engine/tokens/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ ng_module(
1313
deps = [
1414
"@npm//@angular/core",
1515
"@npm//@types/express",
16-
"@npm//@types/express-serve-static-core",
1716
],
1817
)

modules/express-engine/tokens/injection-tokens.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*/
88
import { InjectionToken } from '@angular/core';
99
import { Request, Response } from 'express';
10-
import { ParamsDictionary } from 'express-serve-static-core';
1110

12-
export const REQUEST = new InjectionToken<Request<ParamsDictionary>>('REQUEST');
13-
export const RESPONSE = new InjectionToken<Response>('RESPONSE');
11+
export const REQUEST: InjectionToken<Request> = new InjectionToken<Request>('REQUEST');
12+
export const RESPONSE: InjectionToken<Response> = new InjectionToken<Response>('RESPONSE');

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
"@schematics/angular": "^10.0.0-rc.0",
6868
"@types/browser-sync": "^2.26.1",
6969
"@types/express": "4.17.6",
70-
"@types/express-serve-static-core": "4.17.7",
7170
"@types/fs-extra": "^9.0.0",
7271
"@types/hapi__hapi": "^19.0.0",
7372
"@types/hapi__inert": "^5.2.0",

yarn.lock

-9
Original file line numberDiff line numberDiff line change
@@ -1556,15 +1556,6 @@
15561556
"@types/node" "*"
15571557
"@types/range-parser" "*"
15581558

1559-
"@types/express-serve-static-core@4.17.7":
1560-
version "4.17.7"
1561-
resolved "https://registry.yarnpkg.com/@types/express-serve-static-core/-/express-serve-static-core-4.17.7.tgz#dfe61f870eb549dc6d7e12050901847c7d7e915b"
1562-
integrity sha512-EMgTj/DF9qpgLXyc+Btimg+XoH7A2liE8uKul8qSmMTHCeNYzydDKFdsJskDvw42UsesCnhO63dO0Grbj8J4Dw==
1563-
dependencies:
1564-
"@types/node" "*"
1565-
"@types/qs" "*"
1566-
"@types/range-parser" "*"
1567-
15681559
"@types/express@4.17.6":
15691560
version "4.17.6"
15701561
resolved "https://registry.yarnpkg.com/@types/express/-/express-4.17.6.tgz#6bce49e49570507b86ea1b07b806f04697fac45e"

0 commit comments

Comments
 (0)