Skip to content

Commit 8f960bb

Browse files
authored
Fix table color (alshedivat#1424)
Fix table color when dark mode is default. --------- Signed-off-by: George Araujo <george.gcac@gmail.com>
1 parent d037850 commit 8f960bb

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

_config.yml

+2
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,8 @@ bootstrap:
378378
integrity:
379379
css: "sha256-DF7Zhf293AJxJNTmh5zhoYYIMs2oXitRfBjY+9L//AY="
380380
js: "sha256-fgLAgv7fyCGopR/gBNq2iW3ZKIdqIcyshnUULC4vex8="
381+
bootstrap-table:
382+
version: "1.21.4"
381383
fontawesome:
382384
version: "5.15.4"
383385
integrity: "sha256-mUZM63G8m73Mcidfrv5E+Y61y7a12O5mW4ezU3bxqW4="

_includes/head.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/mdbootstrap@{{ site.mdb.version }}/css/mdb.min.css" integrity="{{ site.mdb.integrity.css }}" crossorigin="anonymous" />
77

88
<!-- Bootstrap Table -->
9-
<link defer rel="stylesheet" href="https://unpkg.com/bootstrap-table@1.21.3/dist/bootstrap-table.min.css">
9+
<link defer rel="stylesheet" href="https://unpkg.com/bootstrap-table@{{ site.bootstrap-table.version }}/dist/bootstrap-table.min.css">
1010

1111
<!-- Fonts & Icons -->
1212
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free@{{ site.fontawesome.version }}/css/all.min.css" integrity="{{ site.fontawesome.integrity }}" crossorigin="anonymous">

_includes/scripts/misc.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
{% endif %}
1818

1919
<!-- Bootstrap Table -->
20-
<script defer src="https://unpkg.com/bootstrap-table@1.21.3/dist/bootstrap-table.min.js"></script>
20+
<script defer src="https://unpkg.com/bootstrap-table@{{ site.bootstrap-table.version }}/dist/bootstrap-table.min.js"></script>
2121

2222
<!-- Load Common JS -->
2323
<script src="{{ '/assets/js/no_defer.js' | relative_url }}"></script>

_sass/_base.scss

+4-1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ table.table a {
4848
}
4949
}
5050

51+
.table-dark {
52+
background-color: transparent;
53+
}
54+
5155
figure,
5256
img {
5357
max-width: 90vw;
@@ -946,4 +950,3 @@ nav[data-toggle="toc"] {
946950
top: 0;
947951
}
948952
}
949-

assets/js/no_defer.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
// add bootstrap classes to tables
22
$(document).ready(function() {
33
$('table').each(function() {
4+
if (document.documentElement.getAttribute("data-theme") == "dark") {
5+
$(this).addClass('table-dark');
6+
} else {
7+
$(this).removeClass('table-dark');
8+
}
9+
410
// only select tables that are not inside an element with "news" (about page) or "card" (cv page) class
511
if($(this).parents('[class*="news"]').length==0 &&
612
$(this).parents('[class*="card"]').length==0 &&
@@ -10,12 +16,6 @@ $(document).ready(function() {
1016
// add some classes to make the table look better
1117
// $(this).addClass('table-sm');
1218
$(this).addClass('table-hover');
13-
14-
if (document.documentElement.getAttribute("data-theme") == "dark") {
15-
$(this).addClass('table-dark');
16-
} else {
17-
$(this).removeClass('table-dark');
18-
}
1919
}
2020
})
2121
});

0 commit comments

Comments
 (0)