Skip to content

Commit 73965a5

Browse files
committed
prepare more
1 parent 338b951 commit 73965a5

9 files changed

+41
-22
lines changed

.gitignore

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
11
/vendor
2-
composer.lock
2+
composer.lock
3+
/.idea
4+
/.php_cs.cache
5+
/.phpstorm.meta.php
6+
_ide_helper_models.php

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
"illuminate/database": "5.2.*"
2727
},
2828
"require-dev": {
29-
"orchestra/testbench": "3.*",
30-
"orchestra/database": "3.*",
31-
"phpunit/phpunit": ">5.0"
29+
"orchestra/testbench": ">=3.0",
30+
"orchestra/database": ">=3.0",
31+
"phpunit/phpunit": "~5.0"
3232
},
3333
"autoload": {
3434
"psr-4": {

tests/Models/Location.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
77
use Illuminate\Database\Eloquent\SoftDeletes;
88

9-
class User extends BaseModel implements AuthenticatableContract
9+
class Location extends BaseModel
1010
{
1111
protected $table = 'locations';
1212

13-
protected $fillable = ['address'];
13+
protected $fillable = ['address', 'seller_id'];
1414
}

tests/Models/Order.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
namespace Fico7489\Laravel\SortJoin\Tests\Models;
44

5-
class Role extends BaseModel
5+
class Order extends BaseModel
66
{
77
protected $table = 'orders';
88

9-
protected $fillable = ['number'];
9+
protected $fillable = ['number', 'seller_id'];
1010

1111
public function seller()
1212
{

tests/Models/OrderItem.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class OrderItem extends BaseModel
66
{
77
protected $table = 'order_items';
88

9-
protected $fillable = ['name'];
9+
protected $fillable = ['name', 'order_id'];
1010

1111
public function order()
1212
{

tests/Models/Seller.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace Fico7489\Laravel\SortJoin\Tests\Models;
44

5-
class User extends BaseModel
5+
class Seller extends BaseModel
66
{
77
protected $table = 'sellers';
88

tests/SortJoinTraitTest.php

+23-5
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,38 @@
22

33
namespace Fico7489\Laravel\SortJoin\Tests;
44

5-
use Illuminate\Database\Eloquent\Model;
5+
use Fico7489\Laravel\SortJoin\Tests\Models\Seller;
6+
use Fico7489\Laravel\SortJoin\Tests\Models\Order;
7+
use Fico7489\Laravel\SortJoin\Tests\Models\OrderItem;
8+
use Fico7489\Laravel\SortJoin\Tests\Models\Location;
69

710
class SortJoinTraitTest extends TestCase
811
{
9-
static $events = [];
10-
1112
public function setUp()
1213
{
1314
parent::setUp();
1415

15-
//
16+
$seller = Seller::create(['title' => 'title']);
17+
$seller2 = Seller::create(['title' => 'title2']);
18+
$seller3 = Seller::create(['title' => 'title3']);
19+
$seller4 = Seller::create(['title' => 'title4']);
20+
21+
$location = Location::create(['address' => 'address', 'seller_id' => $seller->id]);
22+
$location2 = Location::create(['address' => 'address2', 'seller_id' => $seller2->id]);
23+
$location3 = Location::create(['address' => 'address3', 'seller_id' => $seller3->id]);
24+
$location4 = Location::create(['address' => 'address4', 'seller_id' => $seller3->id]);
25+
26+
$order = Order::create(['number' => '1', 'seller_id' => $seller->id]);
27+
$order2 = Order::create(['number' => '2', 'seller_id' => $seller2->id]);
28+
$order3 = Order::create(['number' => '3', 'seller_id' => $seller3->id]);
29+
30+
$orderItem = OrderItem::create(['name' => '1', 'seller_id' => $seller->id]);
31+
$orderItem2 = OrderItem::create(['name' => '2', 'seller_id' => $seller2->id]);
32+
$orderItem3 = OrderItem::create(['name' => '3', 'seller_id' => $seller3->id]);
33+
$orderItem4 = OrderItem::create(['name' => '4', 'seller_id' => $seller->id]);
1634
}
1735

18-
public function test_First()
36+
public function test_OrderByJoin()
1937
{
2038
$this->assertTrue(true);
2139
}

tests/TestCase.php

-3
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
namespace Fico7489\Laravel\SortJoin\Tests;
44

5-
use Fico7489\Laravel\RevisionableUpgrade\Providers\RevisionableUpgradeServiceProvider;
6-
75
abstract class TestCase extends \Orchestra\Testbench\TestCase
86
{
97
public function setUp()
@@ -14,7 +12,6 @@ public function setUp()
1412
protected function getEnvironmentSetUp($app)
1513
{
1614
// Setup default database to use sqlite :memory:
17-
$app['config']->set('auth.model', \Fico7489\Laravel\RevisionableUpgrade\Tests\Models\User::class);
1815
$app['config']->set('database.default', 'testbench');
1916
$app['config']->set('database.connections.testbench', [
2017
'driver' => 'sqlite',

tests/database/migrations/2017_11_04_163552_create_database.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ class CreateDatabase extends Migration
1616
*/
1717
public function up()
1818
{
19-
Schema::create('order_item', function (Blueprint $table) {
19+
Schema::create('order_items', function (Blueprint $table) {
2020
$table->increments('id');
2121
$table->string('name');
22-
$table->integer('order_id')->unsigned()->index();
22+
$table->integer('order_id')->unsigned()->index()->nullable();
2323

2424
$table->foreign('order_id')->references('id')->on('orders')
2525
->onUpdate('cascade')->onDelete('cascade');
@@ -31,7 +31,7 @@ public function up()
3131
Schema::create('orders', function (Blueprint $table) {
3232
$table->increments('id');
3333
$table->string('number')->nullable();
34-
$table->integer('seller_id')->unsigned()->index();
34+
$table->integer('seller_id')->unsigned()->index()->nullable();
3535

3636
$table->foreign('seller_id')->references('id')->on('sellers')
3737
->onUpdate('cascade')->onDelete('cascade');
@@ -51,7 +51,7 @@ public function up()
5151
Schema::create('locations', function (Blueprint $table) {
5252
$table->increments('id');
5353
$table->string('address')->nullable();
54-
$table->integer('seller_id')->unsigned()->index();
54+
$table->integer('seller_id')->unsigned()->index()->nullable();
5555

5656
$table->foreign('seller_id')->references('id')->on('sellers')
5757
->onUpdate('cascade')->onDelete('cascade');

0 commit comments

Comments
 (0)