Skip to content

fix(angular-query): fix injectInfiniteQuery to narrow type after isSuccess #9016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(angular-query): fix injectInfiniteQuery to narrow type after isSuccess #9016

wants to merge 3 commits into from

Conversation

gs18004
Copy link
Contributor

@gs18004 gs18004 commented Apr 14, 2025

closes #8984

I fixed injectInfiniteQuery to narrow type after isSuccess.
Also, I wrote a test for this case.

const infiniteQuery = injectInfiniteQuery(() => ({
  queryKey: ["projects"],
  queryFn: ({ pageParam }) => {
    return Promise.resolve(5);
  },
  initialPageParam: 2,
  getPreviousPageParam: (firstPage) => 1,
  getNextPageParam: (lastPage) => 3,
}));

if (infiniteQuery.isSuccess()) {
  // ✅ after checking isSuccess data signal is not possibly undefined
  const data = infiniteQuery.data();
}

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 632f06f.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 42s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-17 19:05:22 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 14, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9016

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9016

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9016

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9016

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9016

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9016

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9016

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9016

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9016

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9016

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9016

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9016

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9016

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9016

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9016

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9016

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9016

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9016

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9016

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9016

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9016

commit: 632f06f

@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (d1255a8) to head (632f06f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9016       +/-   ##
===========================================
+ Coverage   44.58%   86.16%   +41.57%     
===========================================
  Files         203       17      -186     
  Lines        8106      318     -7788     
  Branches     1803       70     -1733     
===========================================
- Hits         3614      274     -3340     
+ Misses       4060       39     -4021     
+ Partials      432        5      -427
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular: no type narrowing on infinite query status
1 participant
@gs18004