Skip to content

Commit 1fc8b45

Browse files
author
jan
committed
Share the counter with all the test so it continues
1 parent 835f45a commit 1fc8b45

7 files changed

+13
-19
lines changed

io.sloeber.tests/src/io/sloeber/core/CompileAndUpload.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
@RunWith(Parameterized.class)
4848
public class CompileAndUpload {
4949
private static final boolean reinstall_boards_and_libraries = false;
50-
private static int mCounter = 0;
5150
private MCUBoard myBoard;
5251
private String myName;
5352
private static String interval = "1500";// change between 1500 and 100
@@ -161,7 +160,7 @@ public void Build_Verify_upload(CodeDescription codeDescriptor,
161160

162161
IProject theTestProject = null;
163162
NullProgressMonitor monitor = new NullProgressMonitor();
164-
String projectName = String.format("%05d_%s", Integer.valueOf(mCounter++),
163+
String projectName = String.format("%05d_%s", Integer.valueOf(Shared.buildCounter++),
165164
this.myName);
166165
try {
167166
theTestProject = SloeberProject.createArduinoProject(projectName, null,

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileArduinoIDEExamplesOnAVRHardwareTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public class CreateAndCompileArduinoIDEExamplesOnAVRHardwareTest {
3838
private CodeDescription myCodeDescriptor;
3939
private MCUBoard myBoard;
4040
private String myProjectName;
41-
private static int myBuildCounter = 0;
4241
private static int myTotalFails = 0;
4342
private static int maxFails = 50;
4443
private static int mySkipAtStart = 0;
@@ -93,7 +92,7 @@ private static boolean skipExample(Example example) {
9392
@Test
9493
public void testExample() {
9594

96-
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", myBuildCounter++ >= mySkipAtStart);
95+
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", Shared.buildCounter++ >= mySkipAtStart);
9796
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
9897

9998
if (!Shared.BuildAndVerify(myProjectName, myBoard.getBoardDescriptor(), myCodeDescriptor,

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileDefaultInoOnAllBoardsTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class CreateAndCompileDefaultInoOnAllBoardsTest {
3232
private static final boolean skipPlatformInstallation = false;
3333
private static final boolean apply_known_work_Arounds = true;
3434
private static final boolean closeFailedProjects = false;
35-
private static int myBuildCounter = 0;
35+
3636
private static int myTotalFails = 0;
3737
private static int maxFails = 50;
3838
private static int mySkipTestsAtStart = 0;
@@ -346,13 +346,13 @@ public static void installAdditionalBoards() {
346346

347347
@Test
348348
public void testBoard() throws Exception {
349-
myBuildCounter++;
350-
Assume.assumeTrue("Skipping first " + mySkipTestsAtStart + " tests", myBuildCounter >= mySkipTestsAtStart);
349+
Shared.buildCounter++;
350+
Assume.assumeTrue("Skipping first " + mySkipTestsAtStart + " tests", Shared.buildCounter >= mySkipTestsAtStart);
351351
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
352352

353353
IPath templateFolder = Shared.getTemplateFolder("CreateAndCompileTest");
354354
if (!Shared.BuildAndVerify(this.mBoard, CodeDescription.createCustomTemplate(templateFolder), null,
355-
myBuildCounter)) {
355+
Shared.buildCounter)) {
356356
myTotalFails++;
357357
fail(Shared.getLastFailMessage());
358358
}

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileExamplesTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public class CreateAndCompileExamplesTest {
3535
private static final boolean reinstall_boards_and_examples = false;
3636
private CodeDescription myCodeDescriptor;
3737
private BoardDescription myBoardDescriptor;
38-
private static int myBuildCounter = 0;
3938
private static int myTotalFails = 0;
4039
private static int maxFails = 200;
4140
private static int mySkipAtStart = 0;
@@ -124,10 +123,10 @@ public void testExamples() {
124123
// There are only a number of issues you can handle
125124
// best is to focus on the first ones and then rerun starting with the
126125
// failures
127-
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", myBuildCounter++ >= mySkipAtStart);
126+
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", Shared.buildCounter++ >= mySkipAtStart);
128127
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
129128

130-
myBuildCounter++;
129+
Shared.buildCounter++;
131130
if (!Shared.BuildAndVerify(myName, myBoardDescriptor, myCodeDescriptor, new CompileDescription())) {
132131
myTotalFails++;
133132
fail(Shared.getLastFailMessage() );

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileLibraryExamplesTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ public class CreateAndCompileLibraryExamplesTest {
3636
private static final int maxFails = 100;
3737
private static final int mySkipAtStart = 0;
3838

39-
private static int myBuildCounter = 0;
4039
private static int myTotalFails = 0;
4140
private Example myExample;
4241
private MCUBoard myBoard;
@@ -113,7 +112,7 @@ public static void installAdditionalBoards() {
113112
@Test
114113
public void testExamples() {
115114

116-
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", myBuildCounter++ >= mySkipAtStart);
115+
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", Shared.buildCounter++ >= mySkipAtStart);
117116
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
118117
if (!myBoard.isExampleSupported(myExample)) {
119118
fail("Trying to run a test on unsoprted board");

io.sloeber.tests/src/io/sloeber/core/NightlyBoardPatronTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
@RunWith(Parameterized.class)
2828
public class NightlyBoardPatronTest {
2929

30-
private static int myBuildCounter = 0;
3130
private Example myExample;
3231
private MCUBoard myBoardID;
3332
private static int mySkipAtStart = 0;
@@ -80,8 +79,8 @@ public static Collection examples() {
8079

8180
@Test
8281
public void testExamples() {
83-
myBuildCounter++ ;
84-
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", myBuildCounter >= mySkipAtStart);
82+
Shared.buildCounter++ ;
83+
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", Shared.buildCounter >= mySkipAtStart);
8584
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
8685

8786
ArrayList<IPath> paths = new ArrayList<>();
@@ -92,7 +91,7 @@ public void testExamples() {
9291
Map<String, String> boardOptions = myBoardID.getBoardOptions(myExample);
9392
BoardDescription boardDescriptor = myBoardID.getBoardDescriptor();
9493
boardDescriptor.setOptions(boardOptions);
95-
if(!Shared.BuildAndVerify(myBoardID.getBoardDescriptor(), codeDescriptor, myCompileOptions,myBuildCounter)) {
94+
if(!Shared.BuildAndVerify(myBoardID.getBoardDescriptor(), codeDescriptor, myCompileOptions,Shared.buildCounter)) {
9695
myTotalFails++;
9796
fail(Shared.getLastFailMessage() );
9897
}

io.sloeber.tests/src/io/sloeber/core/Shared.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import java.net.URL;
1111
import java.nio.file.Files;
1212
import java.nio.file.Paths;
13-
import java.util.HashMap;
14-
import java.util.Map;
1513
import java.util.zip.ZipEntry;
1614
import java.util.zip.ZipInputStream;
1715

@@ -46,6 +44,7 @@
4644

4745
@SuppressWarnings("nls")
4846
public class Shared {
47+
public static int buildCounter = 0;
4948
private static boolean deleteProjects = true;
5049

5150
public static void setDeleteProjects(boolean deleteProjects) {

0 commit comments

Comments
 (0)