Skip to content

Commit dee3819

Browse files
authored
Minor fix: optimize var usage (operator-framework#917)
1 parent e0800b8 commit dee3819

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java

+8-5
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ public UpdateControl<WebPage> reconcile(WebPage webPage, Context context) {
3838
}
3939

4040
String ns = webPage.getMetadata().getNamespace();
41+
String configMapName = configMapName(webPage);
42+
String deploymentName = deploymentName(webPage);
4143

4244
Map<String, String> data = new HashMap<>();
4345
data.put("index.html", webPage.getSpec().getHtml());
@@ -46,30 +48,31 @@ public UpdateControl<WebPage> reconcile(WebPage webPage, Context context) {
4648
new ConfigMapBuilder()
4749
.withMetadata(
4850
new ObjectMetaBuilder()
49-
.withName(configMapName(webPage))
51+
.withName(configMapName)
5052
.withNamespace(ns)
5153
.build())
5254
.withData(data)
5355
.build();
5456

5557
Deployment deployment = loadYaml(Deployment.class, "deployment.yaml");
56-
deployment.getMetadata().setName(deploymentName(webPage));
58+
deployment.getMetadata().setName(deploymentName);
5759
deployment.getMetadata().setNamespace(ns);
58-
deployment.getSpec().getSelector().getMatchLabels().put("app", deploymentName(webPage));
60+
deployment.getSpec().getSelector().getMatchLabels().put("app", deploymentName);
61+
5962
deployment
6063
.getSpec()
6164
.getTemplate()
6265
.getMetadata()
6366
.getLabels()
64-
.put("app", deploymentName(webPage));
67+
.put("app", deploymentName);
6568
deployment
6669
.getSpec()
6770
.getTemplate()
6871
.getSpec()
6972
.getVolumes()
7073
.get(0)
7174
.setConfigMap(
72-
new ConfigMapVolumeSourceBuilder().withName(configMapName(webPage)).build());
75+
new ConfigMapVolumeSourceBuilder().withName(configMapName).build());
7376

7477
Service service = loadYaml(Service.class, "service.yaml");
7578
service.getMetadata().setName(serviceName(webPage));

0 commit comments

Comments
 (0)