-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Expected Conditions example for Python #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@harsha509 can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @cgoldberg !
* Add Expected Conditions example for Python * Remove import and adjust line numbers 46c35d6
User description
Description
This PR adds an example for Expected Conditions in Python.
Motivation and Context
Example was missing.
Types of changes
Checklist
(I don't have the GitHub CI Token setup, so I couldn't see the code examples when running hugo)
PR Type
Enhancement, Documentation, Tests
Description
Added a Python example for Expected Conditions usage.
Updated documentation in four languages to embed the new Python example.
Improved test coverage for Selenium Expected Conditions in Python.
Changes walkthrough 📝
test_expected_conditions.py
Add Python test for Selenium Expected Conditions
examples/python/tests/support/test_expected_conditions.py
expected_conditions.en.md
Embed Python Expected Conditions example in English docs
website_and_docs/content/documentation/webdriver/support_features/expected_conditions.en.md
gh-codeblock
for Python example.expected_conditions.ja.md
Embed Python Expected Conditions example in Japanese docs
website_and_docs/content/documentation/webdriver/support_features/expected_conditions.ja.md
gh-codeblock
for Python example in Japanese docs.expected_conditions.pt-br.md
Embed Python Expected Conditions example in Portuguese docs
website_and_docs/content/documentation/webdriver/support_features/expected_conditions.pt-br.md
gh-codeblock
for Python example in Portuguese docs.expected_conditions.zh-cn.md
Embed Python Expected Conditions example in Chinese docs
website_and_docs/content/documentation/webdriver/support_features/expected_conditions.zh-cn.md
gh-codeblock
for Python example in Chinese docs.