Skip to content

[deploy site] added community event info #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Apr 9, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
added community event info
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

added community event info

Description

added community event info

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement, Documentation


Description

  • Updated announcement banner text for clarity and engagement.

  • Improved call-to-action link text for better user interaction.


Changes walkthrough 📝

Relevant files
Enhancement
announcement-banner.html
Refined announcement banner text and link                               

website_and_docs/layouts/partials/announcement-banner.html

  • Modified banner text for improved clarity and engagement.
  • Updated call-to-action link text to "Join us!".
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Apr 9, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit e59c394

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Typo

    The word "Episode" is misspelled as "Episde" in the old text, but this typo has been corrected in the new version.

    Tune in for the Selenium Community Live scheduled for April 25th, 2025. 
    <a href="https://www.linkedin.com/events/seleniumcommunitylive-episode57315712465407733761/theater/" target='_blank' aria-pressed="true">Join us!</a>

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 9, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Include complete event name

    The event name is incomplete. The banner should specify "Selenium Community Live
    Episode 5" to maintain consistency with the event's full name as shown in the
    LinkedIn URL.

    website_and_docs/layouts/partials/announcement-banner.html [8-11]

     <h4 class="alert-heading text-center m-2">
    -            Tune in for the Selenium Community Live scheduled for April 25th, 2025. 
    +            Tune in for the Selenium Community Live Episode 5 scheduled for April 25th, 2025. 
                 <a href="https://www.linkedin.com/events/seleniumcommunitylive-episode57315712465407733761/theater/" target='_blank' aria-pressed="true">Join us!</a>
             </h4>
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies that the PR removed the episode number ("Episode 5") from the event name, which is inconsistent with the LinkedIn event URL that still contains this information. Restoring this detail improves clarity and consistency.

    Medium
    • More

    @pallavigitwork pallavigitwork merged commit ec63f7a into SeleniumHQ:trunk Apr 9, 2025
    3 checks passed
    @pallavigitwork pallavigitwork deleted the updateweb-pal branch April 21, 2025 12:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant