Skip to content

Include note about CHROME context in Firefox 138 #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

bonigarcia
Copy link
Member

@bonigarcia bonigarcia commented Mar 26, 2025

User description

Description

This PR includes a note about the use of the argument --allow-system-access to switch the context to CHROME as of Firefox 138.

Motivation and Context

As conversation with whimboo in Slack: https://seleniumhq.slack.com/archives/CBH302726/p1742974853353729

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Added a note about --allow-system-access for Firefox 138.

  • Updated documentation in multiple languages (EN, JA, PT-BR, ZH-CN).


Changes walkthrough 📝

Relevant files
Documentation
firefox.en.md
Add note about `--allow-system-access` in English documentation

website_and_docs/content/documentation/webdriver/browsers/firefox.en.md

  • Added a note about --allow-system-access for Firefox 138.
  • Clarified its requirement for switching to CHROME context.
  • +2/-0     
    firefox.ja.md
    Add note about `--allow-system-access` in Japanese documentation

    website_and_docs/content/documentation/webdriver/browsers/firefox.ja.md

  • Added a note about --allow-system-access for Firefox 138.
  • Clarified its requirement for switching to CHROME context.
  • +2/-0     
    firefox.pt-br.md
    Add note about --allow-system-access in Portuguese (Brazil)
    documentation

    website_and_docs/content/documentation/webdriver/browsers/firefox.pt-br.md

  • Added a note about --allow-system-access for Firefox 138.
  • Clarified its requirement for switching to CHROME context.
  • +2/-0     
    firefox.zh-cn.md
    Add note about --allow-system-access in Chinese (Simplified)
    documentation

    website_and_docs/content/documentation/webdriver/browsers/firefox.zh-cn.md

  • Added a note about --allow-system-access for Firefox 138.
  • Clarified its requirement for switching to CHROME context.
  • +2/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Translation Needed

    The note about Firefox 138 is added in English to the Japanese documentation file. Consider translating this note to Japanese for consistency.

    **Note**: As of Firefox 138, geckodriver needs to be started with the argument `--allow-system-access` to switch the context to `CHROME`.
    Translation Needed

    The note about Firefox 138 is added in English to the Portuguese (Brazil) documentation file. Consider translating this note to Portuguese for consistency.

    **Note**: As of Firefox 138, geckodriver needs to be started with the argument `--allow-system-access` to switch the context to `CHROME`.
    Translation Needed

    The note about Firefox 138 is added in English to the Chinese documentation file. Consider translating this note to Chinese for consistency.

    **Note**: As of Firefox 138, geckodriver needs to be started with the argument `--allow-system-access` to switch the context to `CHROME`.

    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 26, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Add code example

    Consider adding a code example showing how to use the --allow-system-access
    argument with geckodriver to make the documentation more actionable for users.

    website_and_docs/content/documentation/webdriver/browsers/firefox.en.md [463]

     **Note**: As of Firefox 138, geckodriver needs to be started with the argument `--allow-system-access` to switch the context to `CHROME`.
     
    +```bash
    +geckodriver --allow-system-access
    +```
    +
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: Adding a code example demonstrating how to use the --allow-system-access argument makes the documentation more practical and user-friendly. This enhances usability by providing a clear implementation example rather than just a textual description.

    Medium
    • Update

    Copy link

    netlify bot commented Mar 26, 2025

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 98732a0
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/67e3e2b3bb1fc30008381c51
    😎 Deploy Preview https://deploy-preview-2242--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @bonigarcia !

    @harsha509 harsha509 merged commit 51d0cae into trunk Mar 26, 2025
    6 checks passed
    @harsha509 harsha509 deleted the firefox138_context branch March 26, 2025 12:19
    selenium-ci added a commit that referenced this pull request Mar 26, 2025
    Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 51d0cae
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants