Skip to content

Commit f72b544

Browse files
nxpfrankliShawn Guo
authored and
Shawn Guo
committed
arm64: dts: imx8-ss-dma: fix spi lpcg indices
spi0_lpcg: clock-controller@5a400000 { ... Col0 Col1 clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>,// 0 1 <&dma_ipg_clk>; // 1 4 clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>; }; Col1: index, which existing dts try to get. Col2: actual index in lpcg driver. lpspi0: spi@5a000000 { ... clocks = <&spi0_lpcg 0>, <&spi0_lpcg 1>; ^ ^ Should be: clocks = <&spi0_lpcg IMX_LPCG_CLK_0>, <&spi0_lpcg IMX_LPCG_CLK_4>; }; Arg0 is divided by 4 in lpcg driver. <&spi0_lpcg 0> and <&spi0_lpcg 1> are IMX_SC_PM_CLK_PER. Although code can work, code logic is wrong. It should use IMX_LPCG_CLK_0 and IMX_LPCG_CLK_4 for lpcg arg0. Cc: stable@vger.kernel.org Fixes: c409888 ("arm64: dts: imx8dxl: add lpspi support") Signed-off-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
1 parent 808e771 commit f72b544

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ dma_subsys: bus@5a000000 {
2828
#size-cells = <0>;
2929
interrupts = <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>;
3030
interrupt-parent = <&gic>;
31-
clocks = <&spi0_lpcg 0>,
32-
<&spi0_lpcg 1>;
31+
clocks = <&spi0_lpcg IMX_LPCG_CLK_0>,
32+
<&spi0_lpcg IMX_LPCG_CLK_4>;
3333
clock-names = "per", "ipg";
3434
assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>;
3535
assigned-clock-rates = <60000000>;
@@ -44,8 +44,8 @@ dma_subsys: bus@5a000000 {
4444
#size-cells = <0>;
4545
interrupts = <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>;
4646
interrupt-parent = <&gic>;
47-
clocks = <&spi1_lpcg 0>,
48-
<&spi1_lpcg 1>;
47+
clocks = <&spi1_lpcg IMX_LPCG_CLK_0>,
48+
<&spi1_lpcg IMX_LPCG_CLK_4>;
4949
clock-names = "per", "ipg";
5050
assigned-clocks = <&clk IMX_SC_R_SPI_1 IMX_SC_PM_CLK_PER>;
5151
assigned-clock-rates = <60000000>;
@@ -60,8 +60,8 @@ dma_subsys: bus@5a000000 {
6060
#size-cells = <0>;
6161
interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>;
6262
interrupt-parent = <&gic>;
63-
clocks = <&spi2_lpcg 0>,
64-
<&spi2_lpcg 1>;
63+
clocks = <&spi2_lpcg IMX_LPCG_CLK_0>,
64+
<&spi2_lpcg IMX_LPCG_CLK_4>;
6565
clock-names = "per", "ipg";
6666
assigned-clocks = <&clk IMX_SC_R_SPI_2 IMX_SC_PM_CLK_PER>;
6767
assigned-clock-rates = <60000000>;
@@ -76,8 +76,8 @@ dma_subsys: bus@5a000000 {
7676
#size-cells = <0>;
7777
interrupts = <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>;
7878
interrupt-parent = <&gic>;
79-
clocks = <&spi3_lpcg 0>,
80-
<&spi3_lpcg 1>;
79+
clocks = <&spi3_lpcg IMX_LPCG_CLK_0>,
80+
<&spi3_lpcg IMX_LPCG_CLK_4>;
8181
clock-names = "per", "ipg";
8282
assigned-clocks = <&clk IMX_SC_R_SPI_3 IMX_SC_PM_CLK_PER>;
8383
assigned-clock-rates = <60000000>;

0 commit comments

Comments
 (0)