Skip to content

Commit f0c344c

Browse files
ricardongroeck
authored andcommitted
hwmon: (coretemp) Extend the bitmask to read temperature to 0xff
The Intel Software Development manual defines the temperature digital readout as the bits [22:16] of the IA32_[PACKAGE]_THERM_STATUS registers. Bit 23 is specified as reserved. In recent processors, however, the temperature digital readout uses bits [23:16]. In those processors, using the bitmask 0x7f would lead to incorrect readings if the temperature deviates from TjMax by more than 127 degrees Celsius. Although not guaranteed, bit 23 is likely to be 0 in processors from a few generations ago. The temperature reading would still be correct in those processors when using a 0xff bitmask. Model-specific provisions can be made for older processors in which bit 23 is not 0 should the need arise. Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Link: https://lore.kernel.org/r/20240425171311.19519-4-ricardo.neri-calderon@linux.intel.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent f4a8661 commit f0c344c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwmon/coretemp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ static ssize_t show_temp(struct device *dev,
411411
* Return it instead of reporting an error which doesn't
412412
* really help at all.
413413
*/
414-
tdata->temp = tjmax - ((eax >> 16) & 0x7f) * 1000;
414+
tdata->temp = tjmax - ((eax >> 16) & 0xff) * 1000;
415415
tdata->last_updated = jiffies;
416416
}
417417

0 commit comments

Comments
 (0)