Skip to content

Commit cf16f63

Browse files
Uwe Kleine-Königdlezcano
Uwe Kleine-König
authored andcommitted
clocksource/drivers/em_sti: Mark driver as non-removable
The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a em_sti device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230207193010.469495-1-u.kleine-koenig@pengutronix.de Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
1 parent d8c695d commit cf16f63

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/clocksource/em_sti.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,6 @@ static int em_sti_probe(struct platform_device *pdev)
333333
return 0;
334334
}
335335

336-
static int em_sti_remove(struct platform_device *pdev)
337-
{
338-
return -EBUSY; /* cannot unregister clockevent and clocksource */
339-
}
340-
341336
static const struct of_device_id em_sti_dt_ids[] = {
342337
{ .compatible = "renesas,em-sti", },
343338
{},
@@ -346,10 +341,10 @@ MODULE_DEVICE_TABLE(of, em_sti_dt_ids);
346341

347342
static struct platform_driver em_sti_device_driver = {
348343
.probe = em_sti_probe,
349-
.remove = em_sti_remove,
350344
.driver = {
351345
.name = "em_sti",
352346
.of_match_table = em_sti_dt_ids,
347+
.suppress_bind_attrs = true,
353348
}
354349
};
355350

0 commit comments

Comments
 (0)