Skip to content

Commit 996ef31

Browse files
committed
sysctl: remove empty dev table
Now that all the dev sysctls have been moved out we can remove the dev sysctl base directory. We don't need to create base directories, they are created for you as if using 'mkdir -p' with register_syctl() and register_sysctl_init(). For details refer to sysctl_mkdir_p() usage. We save 90 bytes with this changes: ./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remove-dev-table add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90) Function old new delta sysctl_init_bases 111 85 -26 dev_table 64 - -64 Total: Before=21257057, After=21256967, chg -0.00% The empty dev table has been in place since the v2.5.0 days because back then ordering was essentialy. But later commit 7ec66d0 ("sysctl: Stop requiring explicit management of sysctl directories"), merged as of v3.4-rc1, the entire ordering of directories was replaced by allowing sysctl directory autogeneration. This new mechanism introduced on v3.4 allows for sysctl directories to automatically be created for sysctl tables when they are needed and automatically removes them when no sysctl tables use them. That commit also added a dedicated struct ctl_dir as a new type for these autogenerated directories. Reviewed-by: Joel Granados <j.granados@samsung.com> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
1 parent b8cbc08 commit 996ef31

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

kernel/sysctl.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2332,10 +2332,6 @@ static struct ctl_table debug_table[] = {
23322332
{ }
23332333
};
23342334

2335-
static struct ctl_table dev_table[] = {
2336-
{ }
2337-
};
2338-
23392335
int __init sysctl_init_bases(void)
23402336
{
23412337
register_sysctl_init("kernel", kern_table);
@@ -2346,7 +2342,6 @@ int __init sysctl_init_bases(void)
23462342

23472343
register_sysctl_init("vm", vm_table);
23482344
register_sysctl_init("debug", debug_table);
2349-
register_sysctl_init("dev", dev_table);
23502345

23512346
return 0;
23522347
}

0 commit comments

Comments
 (0)