Skip to content

Commit 9412664

Browse files
committed
Merge branch 'i2c/for-current' into i2c/for-mergewindow
2 parents c1ac890 + 2409205 commit 9412664

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

drivers/i2c/busses/i2c-designware-common.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,25 @@ int i2c_dw_set_sda_hold(struct dw_i2c_dev *dev)
441441

442442
void __i2c_dw_disable(struct dw_i2c_dev *dev)
443443
{
444+
unsigned int raw_intr_stats;
445+
unsigned int enable;
444446
int timeout = 100;
447+
bool abort_needed;
445448
unsigned int status;
449+
int ret;
450+
451+
regmap_read(dev->map, DW_IC_RAW_INTR_STAT, &raw_intr_stats);
452+
regmap_read(dev->map, DW_IC_ENABLE, &enable);
453+
454+
abort_needed = raw_intr_stats & DW_IC_INTR_MST_ON_HOLD;
455+
if (abort_needed) {
456+
regmap_write(dev->map, DW_IC_ENABLE, enable | DW_IC_ENABLE_ABORT);
457+
ret = regmap_read_poll_timeout(dev->map, DW_IC_ENABLE, enable,
458+
!(enable & DW_IC_ENABLE_ABORT), 10,
459+
100);
460+
if (ret)
461+
dev_err(dev->dev, "timeout while trying to abort current transfer\n");
462+
}
446463

447464
do {
448465
__i2c_dw_disable_nowait(dev);

drivers/i2c/busses/i2c-designware-core.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@
9898
#define DW_IC_INTR_START_DET BIT(10)
9999
#define DW_IC_INTR_GEN_CALL BIT(11)
100100
#define DW_IC_INTR_RESTART_DET BIT(12)
101+
#define DW_IC_INTR_MST_ON_HOLD BIT(13)
101102

102103
#define DW_IC_INTR_DEFAULT_MASK (DW_IC_INTR_RX_FULL | \
103104
DW_IC_INTR_TX_ABRT | \
@@ -108,6 +109,8 @@
108109
DW_IC_INTR_RX_UNDER | \
109110
DW_IC_INTR_RD_REQ)
110111

112+
#define DW_IC_ENABLE_ABORT BIT(1)
113+
111114
#define DW_IC_STATUS_ACTIVITY BIT(0)
112115
#define DW_IC_STATUS_TFE BIT(2)
113116
#define DW_IC_STATUS_RFNE BIT(3)

drivers/i2c/busses/i2c-i801.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1753,6 +1753,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
17531753
"SMBus I801 adapter at %04lx", priv->smba);
17541754
err = i2c_add_adapter(&priv->adapter);
17551755
if (err) {
1756+
platform_device_unregister(priv->tco_pdev);
17561757
i801_acpi_remove(priv);
17571758
return err;
17581759
}

0 commit comments

Comments
 (0)