Skip to content

Commit 93c6048

Browse files
committed
bus: ti-sysc: Fix missing force mstandby quirk handling
Commit 03856e9 ("bus: ti-sysc: Handle mstandby quirk and use it for musb") added quirk handling for mstandby quirk but did not consider that we also need a quirk variant for SYSC_QUIRK_FORCE_MSTANDBY. We need to use forced idle mode for both SYSC_QUIRK_SWSUP_MSTANDBY and SYSC_QUIRK_FORCE_MSTANDBY, but SYSC_QUIRK_SWSUP_MSTANDBY also need to additionally also configure no-idle mode when enabled. Fixes: 03856e9 ("bus: ti-sysc: Handle mstandby quirk and use it for musb") Signed-off-by: Tony Lindgren <tony@atomide.com>
1 parent e42617b commit 93c6048

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

drivers/bus/ti-sysc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,8 @@ static int sysc_disable_module(struct device *dev)
981981
return ret;
982982
}
983983

984-
if (ddata->cfg.quirks & SYSC_QUIRK_SWSUP_MSTANDBY)
984+
if (ddata->cfg.quirks & (SYSC_QUIRK_SWSUP_MSTANDBY) ||
985+
ddata->cfg.quirks & (SYSC_QUIRK_FORCE_MSTANDBY))
985986
best_mode = SYSC_IDLE_FORCE;
986987

987988
reg &= ~(SYSC_IDLE_MASK << regbits->midle_shift);

include/linux/platform_data/ti-sysc.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ struct sysc_regbits {
4949
s8 emufree_shift;
5050
};
5151

52+
#define SYSC_QUIRK_FORCE_MSTANDBY BIT(20)
5253
#define SYSC_MODULE_QUIRK_AESS BIT(19)
5354
#define SYSC_MODULE_QUIRK_SGX BIT(18)
5455
#define SYSC_MODULE_QUIRK_HDQ1W BIT(17)

0 commit comments

Comments
 (0)