Skip to content

Commit 8197508

Browse files
nxpfrankliShawn Guo
authored and
Shawn Guo
committed
arm64: dts: imx8-ss-dma: fix adc lpcg indices
adc0_lpcg: clock-controller@5ac80000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>; // 1 4 clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>; }; Col1: index, which existing dts try to get. Col2: actual index in lpcg driver. adc0: adc@5a880000 { clocks = <&adc0_lpcg 0>, <&adc0_lpcg 1>; ^^ ^^ clocks = <&adc0_lpcg IMX_LPCG_CLK_0>, <&adc0_lpcg IMX_LPCG_CLK_4>; Arg0 is divided by 4 in lpcg driver. So adc get IMX_SC_PM_CLK_PER by <&adc0_lpcg 0>, <&adc0_lpcg 1>. Although function can work, code logic is wrong. Fix it by using correct indices. Cc: stable@vger.kernel.org Fixes: 1db044b ("arm64: dts: imx8dxl: add adc0 support") Signed-off-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
1 parent 9055d87 commit 8197508

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,8 @@ dma_subsys: bus@5a000000 {
355355
reg = <0x5a880000 0x10000>;
356356
interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
357357
interrupt-parent = <&gic>;
358-
clocks = <&adc0_lpcg 0>,
359-
<&adc0_lpcg 1>;
358+
clocks = <&adc0_lpcg IMX_LPCG_CLK_0>,
359+
<&adc0_lpcg IMX_LPCG_CLK_4>;
360360
clock-names = "per", "ipg";
361361
assigned-clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>;
362362
assigned-clock-rates = <24000000>;
@@ -370,8 +370,8 @@ dma_subsys: bus@5a000000 {
370370
reg = <0x5a890000 0x10000>;
371371
interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
372372
interrupt-parent = <&gic>;
373-
clocks = <&adc1_lpcg 0>,
374-
<&adc1_lpcg 1>;
373+
clocks = <&adc1_lpcg IMX_LPCG_CLK_0>,
374+
<&adc1_lpcg IMX_LPCG_CLK_4>;
375375
clock-names = "per", "ipg";
376376
assigned-clocks = <&clk IMX_SC_R_ADC_1 IMX_SC_PM_CLK_PER>;
377377
assigned-clock-rates = <24000000>;

0 commit comments

Comments
 (0)