Skip to content

Commit 808e771

Browse files
nxpfrankliShawn Guo
authored and
Shawn Guo
committed
arm64: dts: imx8-ss-conn: fix usb lpcg indices
usb2_lpcg: clock-controller@5b270000 { ... Col1 Col2 clocks = <&conn_ahb_clk>, <&conn_ipg_clk>; // 0 6 clock-indices = <IMX_LPCG_CLK_6>, <IMX_LPCG_CLK_7>; // 0 7 ... }; Col1: index, which existing dts try to get. Col2: actual index in lpcg driver. usbotg1: usb@5b0d0000 { ... clocks = <&usb2_lpcg 0>; ^^ Should be: clocks = <&usb2_lpcg IMX_LPCG_CLK_6>; }; usbphy1: usbphy@5b100000 { clocks = <&usb2_lpcg 1>; ^^ SHould be: clocks = <&usb2_lpcg IMX_LPCG_CLK_7>; }; Arg0 is divided by 4 in lpcg driver. So lpcg will do dummy enable. Fix it by use correct clock indices. Cc: stable@vger.kernel.org Fixes: 8065fc9 ("arm64: dts: imx8dxl: add usb1 and usb2 support") Signed-off-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
1 parent 1d86c2b commit 808e771

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ conn_subsys: bus@5b000000 {
4141
interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
4242
fsl,usbphy = <&usbphy1>;
4343
fsl,usbmisc = <&usbmisc1 0>;
44-
clocks = <&usb2_lpcg 0>;
44+
clocks = <&usb2_lpcg IMX_LPCG_CLK_6>;
4545
ahb-burst-config = <0x0>;
4646
tx-burst-size-dword = <0x10>;
4747
rx-burst-size-dword = <0x10>;
@@ -58,7 +58,7 @@ conn_subsys: bus@5b000000 {
5858
usbphy1: usbphy@5b100000 {
5959
compatible = "fsl,imx7ulp-usbphy";
6060
reg = <0x5b100000 0x1000>;
61-
clocks = <&usb2_lpcg 1>;
61+
clocks = <&usb2_lpcg IMX_LPCG_CLK_7>;
6262
power-domains = <&pd IMX_SC_R_USB_0_PHY>;
6363
status = "disabled";
6464
};

0 commit comments

Comments
 (0)