Skip to content

Commit 7eccb5a

Browse files
robherringvinodkoul
authored andcommitted
dt-bindings: dma: snps,dma-spear1340: Fix data{-,_}width schema
'data-width' and 'data_width' properties are defined as arrays, but the schema is defined as a matrix. That works currently since everything gets decoded in to matrices, but that is internal to dtschema and could change. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20240401204354.1691845-1-robh@kernel.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 2b1c1cf commit 7eccb5a

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml

+21-21
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ properties:
9393
data-width:
9494
$ref: /schemas/types.yaml#/definitions/uint32-array
9595
description: Data bus width per each DMA master in bytes.
96+
minItems: 1
97+
maxItems: 4
9698
items:
97-
maxItems: 4
98-
items:
99-
enum: [4, 8, 16, 32]
99+
enum: [4, 8, 16, 32]
100100

101101
data_width:
102102
$ref: /schemas/types.yaml#/definitions/uint32-array
@@ -106,28 +106,28 @@ properties:
106106
deprecated. It' usage is discouraged in favor of data-width one. Moreover
107107
the property incorrectly permits to define data-bus width of 8 and 16
108108
bits, which is impossible in accordance with DW DMAC IP-core data book.
109+
minItems: 1
110+
maxItems: 4
109111
items:
110-
maxItems: 4
111-
items:
112-
enum:
113-
- 0 # 8 bits
114-
- 1 # 16 bits
115-
- 2 # 32 bits
116-
- 3 # 64 bits
117-
- 4 # 128 bits
118-
- 5 # 256 bits
119-
default: 0
112+
enum:
113+
- 0 # 8 bits
114+
- 1 # 16 bits
115+
- 2 # 32 bits
116+
- 3 # 64 bits
117+
- 4 # 128 bits
118+
- 5 # 256 bits
119+
default: 0
120120

121121
multi-block:
122122
$ref: /schemas/types.yaml#/definitions/uint32-array
123123
description: |
124124
LLP-based multi-block transfer supported by hardware per
125125
each DMA channel.
126+
minItems: 1
127+
maxItems: 8
126128
items:
127-
maxItems: 8
128-
items:
129-
enum: [0, 1]
130-
default: 1
129+
enum: [0, 1]
130+
default: 1
131131

132132
snps,max-burst-len:
133133
$ref: /schemas/types.yaml#/definitions/uint32-array
@@ -138,11 +138,11 @@ properties:
138138
will be from 1 to max-burst-len words. It's an array property with one
139139
cell per channel in the units determined by the value set in the
140140
CTLx.SRC_TR_WIDTH/CTLx.DST_TR_WIDTH fields (data width).
141+
minItems: 1
142+
maxItems: 8
141143
items:
142-
maxItems: 8
143-
items:
144-
enum: [4, 8, 16, 32, 64, 128, 256]
145-
default: 256
144+
enum: [4, 8, 16, 32, 64, 128, 256]
145+
default: 256
146146

147147
snps,dma-protection-control:
148148
$ref: /schemas/types.yaml#/definitions/uint32

0 commit comments

Comments
 (0)