Skip to content

Commit 2f368a9

Browse files
hansendctorvalds
authored andcommitted
mm/vmscan: add helper for querying ability to age anonymous pages
Anonymous pages are kept on their own LRU(s). These lists could theoretically always be scanned and maintained. But, without swap, there is currently nothing the kernel can *do* with the results of a scanned, sorted LRU for anonymous pages. A check for '!total_swap_pages' currently serves as a valid check as to whether anonymous LRUs should be maintained. However, another method will be added shortly: page demotion. Abstract out the 'total_swap_pages' checks into a helper, give it a logically significant name, and check for the possibility of page demotion. [dave.hansen@linux.intel.com: v11] Link: https://lkml.kernel.org/r/20210715055145.195411-7-ying.huang@intel.com Link: https://lkml.kernel.org/r/20210721063926.3024591-6-ying.huang@intel.com Link: https://lkml.kernel.org/r/20210715055145.195411-7-ying.huang@intel.com Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Signed-off-by: "Huang, Ying" <ying.huang@intel.com> Reviewed-by: Yang Shi <shy828301@gmail.com> Reviewed-by: Greg Thelen <gthelen@google.com> Reviewed-by: Zi Yan <ziy@nvidia.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Wei Xu <weixugc@google.com> Cc: Oscar Salvador <osalvador@suse.de> Cc: David Rientjes <rientjes@google.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: David Hildenbrand <david@redhat.com> Cc: Keith Busch <kbusch@kernel.org> Cc: Yang Shi <yang.shi@linux.alibaba.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 668e414 commit 2f368a9

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

mm/vmscan.c

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2734,6 +2734,21 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
27342734
}
27352735
}
27362736

2737+
/*
2738+
* Anonymous LRU management is a waste if there is
2739+
* ultimately no way to reclaim the memory.
2740+
*/
2741+
static bool can_age_anon_pages(struct pglist_data *pgdat,
2742+
struct scan_control *sc)
2743+
{
2744+
/* Aging the anon LRU is valuable if swap is present: */
2745+
if (total_swap_pages > 0)
2746+
return true;
2747+
2748+
/* Also valuable if anon pages can be demoted: */
2749+
return can_demote(pgdat->node_id, sc);
2750+
}
2751+
27372752
static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
27382753
{
27392754
unsigned long nr[NR_LRU_LISTS];
@@ -2843,7 +2858,8 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
28432858
* Even if we did not try to evict anon pages at all, we want to
28442859
* rebalance the anon lru active/inactive ratio.
28452860
*/
2846-
if (total_swap_pages && inactive_is_low(lruvec, LRU_INACTIVE_ANON))
2861+
if (can_age_anon_pages(lruvec_pgdat(lruvec), sc) &&
2862+
inactive_is_low(lruvec, LRU_INACTIVE_ANON))
28472863
shrink_active_list(SWAP_CLUSTER_MAX, lruvec,
28482864
sc, LRU_ACTIVE_ANON);
28492865
}
@@ -3678,7 +3694,7 @@ static void age_active_anon(struct pglist_data *pgdat,
36783694
struct mem_cgroup *memcg;
36793695
struct lruvec *lruvec;
36803696

3681-
if (!total_swap_pages)
3697+
if (!can_age_anon_pages(pgdat, sc))
36823698
return;
36833699

36843700
lruvec = mem_cgroup_lruvec(NULL, pgdat);

0 commit comments

Comments
 (0)