Skip to content

Commit 0064db9

Browse files
dlechbroonie
authored andcommitted
spi: axi-spi-engine: fix version format string
The version format string in the AXI SPI Engine driver was probably intended to print the version number in the same format as the DT compatible string (e.g. 1.00.a). However, the version just uses semantic versioning so formatting the patch number as a character is not correct and would result in printing control characters for patch numbers less than 32. Fixes: b1353d1 ("spi: Add Analog Devices AXI SPI Engine controller support") Signed-off-by: David Lechner <dlechner@baylibre.com> Link: https://lore.kernel.org/r/20240412-axi-spi-engine-version-printf-v1-1-95e1e842c1a6@baylibre.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fec50db commit 0064db9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-axi-spi-engine.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ static int spi_engine_probe(struct platform_device *pdev)
623623

624624
version = readl(spi_engine->base + ADI_AXI_REG_VERSION);
625625
if (ADI_AXI_PCORE_VER_MAJOR(version) != 1) {
626-
dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%c\n",
626+
dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%u\n",
627627
ADI_AXI_PCORE_VER_MAJOR(version),
628628
ADI_AXI_PCORE_VER_MINOR(version),
629629
ADI_AXI_PCORE_VER_PATCH(version));

0 commit comments

Comments
 (0)