Merge pull request TheAlgorithms#230 from christianbender/master

harshildarji · web-flow · commit eb9fe88e1661 · 2017-12-23T18:25:38.000+05:30
improvement XOR_cipher.py
diff --git a/ciphers/XOR_cipher.py b/ciphers/XOR_cipher.py
@@ -38,20 +38,14 @@ def encrypt(self, content, key):
 		# precondition
 		assert (isinstance(key,int) and isinstance(content,str))
 
-		# testing for default arguments
-		if (key == 0):
-			if (self.__key == 0):
-				key = 1
-			else:
-				key = self.__key
+		key = key or self.__key or 1
 
 		# make sure key can be any size
 		while (key > 255):
 			key -= 255
 
 		# This will be returned
 		ans = []
-		resultNumber = 0
 
 		for ch in content:
 			ans.append(chr(ord(ch) ^ key))
@@ -69,20 +63,14 @@ def decrypt(self,content,key):
 		# precondition
 		assert (isinstance(key,int) and isinstance(content,list))
 
-		# testing for default arguments
-		if (key == 0):
-			if (self.__key == 0):
-				key = 1
-			else:
-				key = self.__key
+		key = key or self.__key or 1
 
 		# make sure key can be any size
 		while (key > 255):
 			key -= 255
 
 		# This will be returned
 		ans = []
-		resultNumber = 0
 
 		for ch in content:
 			ans.append(chr(ord(ch) ^ key))
@@ -101,20 +89,14 @@ def encrypt_string(self,content, key = 0):
 		# precondition
 		assert (isinstance(key,int) and isinstance(content,str))
 
-		# testing for default arguments
-		if (key == 0):
-			if (self.__key == 0):
-				key = 1
-			else:
-				key = self.__key
+		key = key or self.__key or 1
 
 		# make sure key can be any size
 		while (key > 255):
 			key -= 255
 
 		# This will be returned
 		ans = ""
-		resultNumber = 0
 
 		for ch in content:
 			ans += chr(ord(ch) ^ key)
@@ -132,21 +114,15 @@ def decrypt_string(self,content,key = 0):
 		# precondition
 		assert (isinstance(key,int) and isinstance(content,str))
 
-		# testing for default arguments
-		if (key == 0):
-			if (self.__key == 0):
-				key = 1
-			else:
-				key = self.__key
+		key = key or self.__key or 1
 
 		# make sure key can be any size
 		while (key > 255):
 			key -= 255
 
 		# This will be returned
 		ans = ""
-		resultNumber = 0
-
+		
 		for ch in content:
 			ans += chr(ord(ch) ^ key)
 
@@ -166,15 +142,12 @@ def encrypt_file(self, file, key = 0):
 		assert (isinstance(file,str) and isinstance(key,int))
 
 		try:
-			fin = open(file,"r")
-			fout = open("encrypt.out","w+")
-
-			# actual encrypt-process
-			for line in fin:
-				fout.write(self.encrypt_string(line,key))
+			with open(file,"r") as fin:
+				with open("encrypt.out","w+") as fout:
 
-			fin.close()
-			fout.close()
+					# actual encrypt-process
+					for line in fin:
+						fout.write(self.encrypt_string(line,key))
 
 		except:
 			return False
@@ -195,15 +168,12 @@ def decrypt_file(self,file, key):
 		assert (isinstance(file,str) and isinstance(key,int))
 
 		try:
-			fin = open(file,"r")
-			fout = open("decrypt.out","w+")
-
-			# actual encrypt-process
-			for line in fin:
-				fout.write(self.decrypt_string(line,key))
+			with open(file,"r") as fin:
+				with open("decrypt.out","w+") as fout:
 
-			fin.close()
-			fout.close()
+					# actual encrypt-process
+					for line in fin:
+						fout.write(self.decrypt_string(line,key))
 
 		except:
 			return False
@@ -233,7 +203,7 @@ def decrypt_file(self,file, key):
 # else:
 # 	print "encrypt unsuccessful"
 
-# if (crypt.decrypt_file("a.out",key)):
+# if (crypt.decrypt_file("encrypt.out",key)):
 # 	print "decrypt successful"
 # else:
 # 	print "decrypt unsuccessful"
