Skip to content

Fix: Address Sonar Blocker issues #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

DrSatyr
Copy link
Collaborator

@DrSatyr DrSatyr commented Apr 24, 2025

No description provided.

@DrSatyr DrSatyr requested a review from Copilot April 24, 2025 21:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses Sonar blocker issues by updating test cases to accurately validate schema differences.

  • In SchemaDiffTest.java, the test now verifies changes in property types rather than default values.
  • In AllOfOneOfDiffTest.java, the assertion is modified to use a clear boolean check with isTrue().

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
core/src/test/java/org/openapitools/openapidiff/core/SchemaDiffTest.java Updated test references and assertions to verify type changes in schema properties.
core/src/test/java/org/openapitools/openapidiff/core/AllOfOneOfDiffTest.java Revised the assertion for core changes to use .isTrue() for clearer boolean validation.
Files not reviewed (2)
  • core/src/test/resources/schemaDiff/schema-props-type-handling-1.yaml: Language not supported
  • core/src/test/resources/schemaDiff/schema-props-type-handling-2.yaml: Language not supported

@DrSatyr DrSatyr merged commit a6df0ad into master Apr 24, 2025
6 checks passed
@DrSatyr DrSatyr deleted the fix/sonar-blocker-schema-tests branch April 24, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant